diff options
| author | Matthias Clasen <mclasen@redhat.com> | 2019-10-28 20:30:21 -0400 |
|---|---|---|
| committer | Matthias Clasen <mclasen@redhat.com> | 2019-10-28 20:30:21 -0400 |
| commit | 511ebfccfd6ca54611d90a5c0ab1f19c8e714422 (patch) | |
| tree | c54c3820d85b9cfd8192f7645a7f3621bf68a698 | |
| parent | b688307468ebbc5afd211bc4e263f6f46fc2b0c6 (diff) | |
| download | pango-511ebfccfd6ca54611d90a5c0ab1f19c8e714422.tar.gz | |
Go back to ignoring underlines for itemization
This is what we used to do, and without it, we
lose kerning beween underlined and non-underlined
characters, which is most noticable with mnemonic
underlines.
Fixes: https://gitlab.gnome.org/GNOME/pango/issues/426
| -rw-r--r-- | pango/pango-layout.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/pango/pango-layout.c b/pango/pango-layout.c index 2863894c..db016614 100644 --- a/pango/pango-layout.c +++ b/pango/pango-layout.c @@ -4085,12 +4085,9 @@ affects_itemization (PangoAttribute *attr, case PANGO_ATTR_ABSOLUTE_SIZE: case PANGO_ATTR_GRAVITY: case PANGO_ATTR_GRAVITY_HINT: - /* These are part of ItemProperties, so need to break runs */ - case PANGO_ATTR_SHAPE: - case PANGO_ATTR_RISE: - case PANGO_ATTR_UNDERLINE: - case PANGO_ATTR_STRIKETHROUGH: + /* These need to be constant across runs */ case PANGO_ATTR_LETTER_SPACING: + case PANGO_ATTR_SHAPE: return TRUE; default: return FALSE; |