diff options
| author | Behdad Esfahbod <behdad@gnome.org> | 2006-02-21 10:47:30 +0000 |
|---|---|---|
| committer | Behdad Esfahbod <behdad@src.gnome.org> | 2006-02-21 10:47:30 +0000 |
| commit | e0babd9ed3f94843d2d8833592bd55895769c009 (patch) | |
| tree | 764c7f23486a5d0ce9b4e86fc664870867402ebb /pango/pango-engine.h | |
| parent | f3f321992201a5daa52bc44042858b2a9992b672 (diff) | |
| download | pango-e0babd9ed3f94843d2d8833592bd55895769c009.tar.gz | |
Bug 331723 – shapers should not crash on failures
2006-02-21 Behdad Esfahbod <behdad@gnome.org>
Bug 331723 – shapers should not crash on failures
* modules/*/*-fc.c: Return instead of g_return_if_fail when
face == NULL.
* pango/pango-engine.h (PangoEngineShape): Document that a shaper
should return an empty glyph string on failure.
Diffstat (limited to 'pango/pango-engine.h')
| -rw-r--r-- | pango/pango-engine.h | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/pango/pango-engine.h b/pango/pango-engine.h index ae101a13..11bb4a8d 100644 --- a/pango/pango-engine.h +++ b/pango/pango-engine.h @@ -163,7 +163,10 @@ struct _PangoEngineShape * of the output logical clusters; * if no rendering is desired for a character, this may involve * inserting glyphs with the #PangoGlyph ID #PANGO_GLYPH_EMPTY, which - * is guaranteed never to render. + * is guaranteed never to render. If the shaping fails for any reason, + * the shaper should return with an empty (zero-size) glyph string. + * If the shaper has not set the size on the glyph string yet, simply + * returning signals the failure too. * @covers: Returns the characters that this engine can cover * with a given font for a given language. If not overridden, the default * implementation simply returns the coverage information for the |