diff options
author | Matthias Clasen <mclasen@redhat.com> | 2018-12-12 15:43:50 -0500 |
---|---|---|
committer | Matthias Clasen <mclasen@redhat.com> | 2018-12-12 15:43:50 -0500 |
commit | 8d39b9ac1d6462a224d37a4cbc0d81b052c0e313 (patch) | |
tree | 826a6ee374332f74f549be062fe08ae21892ab0f /pango/pango-layout.c | |
parent | 26f1135f374f3ad5eb963dcdf016542fbbda361b (diff) | |
download | pango-8d39b9ac1d6462a224d37a4cbc0d81b052c0e313.tar.gz |
Clarify docs around text input
Make it clear that all text input must be valid UTF-8,
except in the case pango_layout_set_text, which we now
officially document as accepting and handling invalid
input.
Diffstat (limited to 'pango/pango-layout.c')
-rw-r--r-- | pango/pango-layout.c | 20 |
1 files changed, 11 insertions, 9 deletions
diff --git a/pango/pango-layout.c b/pango/pango-layout.c index 397c9499..a3850843 100644 --- a/pango/pango-layout.c +++ b/pango/pango-layout.c @@ -1006,7 +1006,7 @@ pango_layout_is_ellipsized (PangoLayout *layout) /** * pango_layout_set_text: * @layout: a #PangoLayout - * @text: a valid UTF-8 string + * @text: the text * @length: maximum length of @text, in bytes. -1 indicates that * the string is nul-terminated and the length should be * calculated. The text will also be truncated on @@ -1014,12 +1014,15 @@ pango_layout_is_ellipsized (PangoLayout *layout) * positive. * * Sets the text of the layout. - * - * Note that if you have used - * pango_layout_set_markup() or pango_layout_set_markup_with_accel() on - * @layout before, you may want to call pango_layout_set_attributes() to clear - * the attributes set on the layout from the markup as this function does not - * clear attributes. + * + * This function validates @text and renders invalid UTF-8 + * with a placeholder glyph. + * + * Note that if you have used pango_layout_set_markup() or + * pango_layout_set_markup_with_accel() on @layout before, you may + * want to call pango_layout_set_attributes() to clear the attributes + * set on the layout from the markup as this function does not clear + * attributes. **/ void pango_layout_set_text (PangoLayout *layout, @@ -1044,8 +1047,7 @@ pango_layout_set_text (PangoLayout *layout, layout->length = strlen (layout->text); - /* validate it, and replace invalid bytes with '?' - */ + /* validate it, and replace invalid bytes with -1 */ start = layout->text; for (;;) { gboolean valid; |