diff options
author | Matthias Clasen <mclasen@redhat.com> | 2022-01-07 21:26:14 -0500 |
---|---|---|
committer | Matthias Clasen <mclasen@redhat.com> | 2022-01-07 21:39:39 -0500 |
commit | d04872ad221b56f80ff20503816fde4dd10636c6 (patch) | |
tree | bdce2d05fb3a3e3b7304764bea1f59288378b012 /pango | |
parent | 65d2e49cebe4a09fba60f612fd343f9d9f008c1c (diff) | |
download | pango-d04872ad221b56f80ff20503816fde4dd10636c6.tar.gz |
Reinstate previous behavior or pango_attr_list_spliceattrlist-splice
If gap is zero, don't limit the inserted attributes;
that does not make sense. Spell out the different
use cases in the docs.
Testcase included.
Fixes: #653
Diffstat (limited to 'pango')
-rw-r--r-- | pango/pango-attributes.c | 20 |
1 files changed, 17 insertions, 3 deletions
diff --git a/pango/pango-attributes.c b/pango/pango-attributes.c index c9b58b07..696f9ba1 100644 --- a/pango/pango-attributes.c +++ b/pango/pango-attributes.c @@ -2289,10 +2289,16 @@ pango_attr_list_update (PangoAttrList *list, * that applies at position @pos in @list by an amount @len, * and then calling [method@Pango.AttrList.change] with a copy * of each attribute in @other in sequence (offset in position - * by @pos, and limited in lengh to @len). + * by @pos, and limited in length to @len). * * This operation proves useful for, for instance, inserting * a pre-edit string in the middle of an edit buffer. + * + * For backwards compatibility, the function behaves differently + * when @len is 0. In this case, the attributes from @other are + * not imited to @len, and are just overlayed on top of @list. + * + * This mode is useful for merging two lists of attributes together. */ void pango_attr_list_splice (PangoAttrList *list, @@ -2347,8 +2353,16 @@ pango_attr_list_splice (PangoAttrList *list, for (i = 0, p = other->attributes->len; i < p; i++) { PangoAttribute *attr = pango_attribute_copy (g_ptr_array_index (other->attributes, i)); - attr->start_index = MIN (CLAMP_ADD (attr->start_index, upos), end); - attr->end_index = MIN (CLAMP_ADD (attr->end_index, upos), end); + if (ulen > 0) + { + attr->start_index = MIN (CLAMP_ADD (attr->start_index, upos), end); + attr->end_index = MIN (CLAMP_ADD (attr->end_index, upos), end); + } + else + { + attr->start_index = CLAMP_ADD (attr->start_index, upos); + attr->end_index = CLAMP_ADD (attr->end_index, upos); + } /* Same as above, the attribute could be squashed to zero-length; here * pango_attr_list_change() will take care of deleting it. |