summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Revert "Merge branch 'ebassi/gir-identifiers' into 'master'"revert-c73c2d5dMatthias Clasen2020-06-101-5/+5
| | | This reverts merge request !197
* Merge branch 'ebassi/gir-identifiers' into 'master'Matthias Clasen2020-06-101-5/+5
|\ | | | | | | | | Use the correct identifier for Pango sub-libraries See merge request GNOME/pango!197
| * Use the correct identifier for Pango sub-librariesEmmanuele Bassi2020-06-101-5/+5
|/ | | | | | | | The Pango sub-libraries sadly hijack the Pango namespace for their symbols, but use a different namespace for the identifiers. This fixes an introspection ABI incompatible change that made its way in Pango 1.45.
* Merge branch 'test-layout-fix' into 'master'Matthias Clasen2020-06-102-2/+2
|\ | | | | | | | | Try to make the layout test less sensitive See merge request GNOME/pango!196
| * Try to make the layout test less sensitiveMatthias Clasen2020-06-102-2/+2
|/ | | | | | Try not to pick a width that makes line-breaking decisions depend on rounding. Lets see if this works better, it makes the test pass locally.
* Merge branch 'fix-gtk2-crash' into 'master'Matthias Clasen2020-06-103-5/+2
|\ | | | | | | | | | | | | Fix a crash in gtk2 Closes #479 See merge request GNOME/pango!195
| * Revert "tests: Update expected output"Matthias Clasen2020-06-102-0/+2
| | | | | | | | This reverts commit 4d8e71471984fb0fc147d1a64695ad5f18576fde.
| * Fix a crash in gtk2Matthias Clasen2020-06-101-5/+0
|/ | | | | | | Apparently, gtk2 assumes that calling pango_layout_set_attributes guarantees that the attribute list gains a ref. Fixes: #479
* Merge branch 'wip/baedert/for-master' into 'master'Matthias Clasen2020-06-109-385/+391
|\ | | | | | | | | Wip/baedert/for master See merge request GNOME/pango!194
| * layout: Ignore setting the attributes to the same listTimm Bäder2020-06-101-0/+4
| |
| * tests: Add some tests for pango_attr_list_equalTimm Bäder2020-06-101-0/+71
| |
| * pango-tabs: Avoid passing NULL to memcpyTimm Bäder2020-06-101-1/+2
| | | | | | | | pango_tab_array_new might not actually allocate anything for ->tabs.
| * pango-layout: Help static analysis a bitTimm Bäder2020-06-101-0/+2
| | | | | | | | | | Make sure we have a valid iter here, which is of course always the case in reality.
| * pangofc-fontmap: Avoid a dead assignmentTimm Bäder2020-06-101-1/+1
| | | | | | | | I believe this was meant to assign to variable and not res.
| * pango-context: avoid assignment to uninitialized valueTimm Bäder2020-06-101-1/+2
| | | | | | | | | | | | | | | | | | We're assigning EMBEDDING_CHANGED to state->changed in update_embedding_end(). At that point state->changed is uninitialized, but that doesn't matter since we later override the value anyway. Just pull the initialization to earlier in that function, which assigns EMBEDDING_CHANGED anyway, so doesn't change anything.
| * pango-ot-info: Fix an uninitialized valueTimm Bäder2020-06-101-3/+4
| | | | | | | | | | | | | | | | | | We never assign a value to l_index. Also, we pass on language_index to hb_ot_layout_script_select_language, even though the last parameter of that function is not nullable, while our language_index parameter is. Fix this to pass &l_index to hb_ot_layout_script_select_language, which is what I believe should happen.
| * pangocairo-render: Make a local constTimm Bäder2020-06-101-1/+1
| | | | | | | | | | | | | | | | Avoiding this warning: ../pango/pangocairo-render.c:506:19: warning: assigning to 'char *' from 'const char *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers] for (row = 0, p = name; row < rows; row++) ^ ~~~~
| * attrs: Remove unused iterator memberTimm Bäder2020-06-101-1/+0
| |
| * attrs: Save attribute list in a GPtrArrayTimm Bäder2020-06-102-302/+231
| |
| * attrlist: Remove attributes_tailTimm Bäder2020-06-102-25/+11
| | | | | | | | It's only very rarely used, and will become even less important later.
| * attrs: Save iterator stack in a GPtrArrayTimm Bäder2020-06-102-59/+71
|/ | | | One less linked list.
* tests: Add an explanationMatthias Clasen2020-06-091-0/+3
| | | | | Lets explain what this test is about, since it doesn't appear to test anything.
* Merge branch 'fix-shape-tab-crash' into 'master'Matthias Clasen2020-06-093-12/+66
|\ | | | | | | | | Fix shape tab crash See merge request GNOME/pango!192
| * Add a test for a crash in shape_tabMatthias Clasen2020-06-092-0/+50
| | | | | | | | This verifies the fix in the previous commit.
| * layout: Fix a crashMatthias Clasen2020-06-091-12/+16
|/ | | | | pango_layout_get_effective_attributes can return NULL. But not all callers were handling that.
* 1.45.11.45.1Matthias Clasen2020-06-082-1/+10
| | | | | | We've been using the 1.45.0 version in git for a while, without ever putting out a tarball. Lets bump the version to 1.45.1 for a new release, to get avoid uncertainties.
* Merge branch 'wip/baedert/for-master2' into 'master'Matthias Clasen2020-06-0811-133/+277
|\ | | | | | | | | Wip/baedert/for master2 See merge request GNOME/pango!190
| * tests: Update expected outputTimm Bäder2020-06-082-2/+0
| | | | | | | | | | We don't set an attribute list in these cases anymore, so reflect that in the output.
| * test-common: Ignore null attr listsTimm Bäder2020-06-081-0/+3
| | | | | | | | | | pango_layout_get_attributes() is explicitly nullable but not every caller handles that case.
| * testattributes: Test iter on empty attr listTimm Bäder2020-06-081-0/+9
| |
| * layout: Treat empty attr lists like NULL onesTimm Bäder2020-06-082-1/+7
| |
| * layout: Unconditionally unref attr listsTimm Bäder2020-06-081-5/+2
| |
| * pango-layout: Try to avoid allocating a new PangoAttrListTimm Bäder2020-06-081-5/+21
| |
| * testattributes: Properly free GStringTimm Bäder2020-06-081-1/+1
| | | | | | | | Not needed afterwards.
| * glyph-item: Allocate attr iterator on the stackTimm Bäder2020-06-081-9/+11
| |
| * break: Only call break_attrs if we really have attributesTimm Bäder2020-06-081-1/+1
| |
| * break: Make a local constTimm Bäder2020-06-081-2/+1
| | | | | | | | Make it clearer that we're not going to modify the attribute
| * break_attrs: Bail out if we have no ALLOW_BREAKS attributesTimm Bäder2020-06-081-0/+6
| |
| * attributes: Add _pango_attr_list_has_attributesTimm Bäder2020-06-082-0/+8
| | | | | | | | A private function to find empty attribute lists
| * layout: Avoid getting the text length if we know it alreadyTimm Bäder2020-06-081-7/+14
| |
| * Allocate internal PangoAttrLists on the stackTimm Bäder2020-06-085-50/+67
| |
| * layout: Add missing (nullable) annotationTimm Bäder2020-06-081-1/+2
| |
| * layotu: Avoid invalidating when setting attrs from NULL to NULLTimm Bäder2020-06-081-1/+5
| |
| * Allocate internal PangoAttrListIterators on the stackTimm Bäder2020-06-083-46/+91
| |
| * layout: Try to avoid some work when creating itersTimm Bäder2020-06-081-6/+19
| | | | | | | | | | Instead of getting the logical rect and then not using it, try not to compute it in the first place.
| * pangocairo-context: Don't invalidate if font options are equalTimm Bäder2020-06-081-1/+9
| |
| * layout: Ignore setting the width if it won't have any effectTimm Bäder2020-06-081-0/+5
| | | | | | | | | | | | This is a pretty weak check (think e.g. a layout containing the text "a\na"), but it's very easy to do and still hits quite a few cases in real-world applications.
* | Merge branch 'for-master' into 'master'Matthias Clasen2020-06-0816-73/+176
|\ \ | | | | | | | | | | | | For master See merge request GNOME/pango!184
| * | tests: Update the locale useEmmanuele Bassi2020-06-083-9/+11
| | | | | | | | | | | | | | | Create the PangoContext for the test after resetting the locale, and use the en_US.utf8 name, as it seems to be the name used by Fedora.
| * | tests: Ensure we respect the TAP output formatEmmanuele Bassi2020-06-083-9/+35
| | | | | | | | | | | | | | | When dumping the diff between the computed and expected results, we need to respect the TAP format and place "#" in front of each line.