| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
| |
Another debug api. This function produces a serialization
of a font that is enough to uniquely identify the font.
This is more detailed than what pango_font_describe
creates.
|
|
|
|
|
|
| |
Json doesn't have comments, so we have to add
an explicit comment value. This will be useful
to describe what test cases are about.
|
|
|
|
|
|
|
| |
If requested, serialize lines, runs, and log attrs.
This will let us use the serialization format to
record not just the test inputs, but outputs as
well.
|
|
|
|
|
|
| |
Add some private api for the serializer to get
the font matrix. This is needed to let the serializer
write a unique fingerprint for the font.
|
| |
|
|
|
|
| |
Avoid writing out empty attributes or tabs.
|
|
|
|
|
|
|
|
|
| |
Optionally include context information in the
serialization and restore it. This will be useful
for transporting for giving tests complete data
that affects their output.
Some tests included.
|
|
|
|
|
|
|
| |
This gives us some room to add more things
to these apis, e.g. a way to store not just
the input part of a layout, but also the
output.
|
| |
|
|
|
|
|
| |
They are produced by deserialization,
so call them that.
|
| |
|
|
|
|
|
| |
Make space actually show up as visible space
when we want that.
|
|
|
|
|
|
|
| |
When handling items that fix completely,
we were not consistently taking extra width
into account, leading to hyphens sticking
out in some cases.
|
|
|
|
|
|
|
| |
When looking at scripts, we want to look
at the script of the *previous* character.
And then we need to exclude SHY from the
common script.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When we take a complete item because there are
no breakpoints, we were inserting a hyphen at
the end even though there may not be a breakpoint
there, and ending up with a hyphen in the middle
of an (overlong) line: Brat-wurst.
Test included.
This but was discovered with the help of
http://gitlab.gnome.org/matthiasc/layout-editor
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
I went a bit overboard in #603. The vertical bar
is too common, and this usage to specialized to
do it by default. To enable this, we should rather
make log attrs tweakable.
We still replace hyphenation points with hyphens.
Fixes: #630
|
|
|
|
|
|
| |
The value does not really matter for these,
but it looks more natural if they have a
value of 1, and not 0.
|
|
|
|
|
|
|
|
| |
Add api to serialize PangoLayout, for the benefit
of testing and debugging. Currently, this uses
json, but that is an implementation detail.
Some tests included.
|
|
|
|
|
|
| |
This code gets run for gtks size-allocation,
and we don't want it to be any slower than it
has to be, when not debugging it.
|
| |
|
|
|
|
|
|
| |
Add an api to serialize PangoAttrList.
This will be useful in testing and debugging.
|
|\
| |
| |
| |
| | |
Rewrite process_item
See merge request GNOME/pango!509
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We must not add the width of the space back to
remaining_width, since we're just correcting the
glyphs to match the accounting that process_item
has already done.
This was showing up as justification operating
on wrong numbers when justifying lines with a
final space, leading to uneven margins.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is not an entire rewrite, the basic approach
to fitting items is still the same. The main difference
here is that we shape and measure a possible breakpoint
before accepting it as candidate for breaking. This
is necessary to ensure that we have accurate width
information when making decisions about this
breakpoint - the width we are calculating based on
log widths is only an approximation (due to things
like clusters, hyphens, final spaces, etc).
To avoid excessive shaping, we only do this extra
work when we are close to the end of the line.
|
|/
|
|
|
|
|
| |
We are using the hb metrics api in more places
now, so just require 2.6.0 where it was introduced.
That version is almost 2 years old now, so that
is hopefully not too much of a burden.
|
| |
|
|
|
|
|
| |
It turns out that we do need to look for longer breakpoints
after all if we want to find optimal solutions.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When looking for breakpoints, we were assuming that
there is no point to keep looking forward once we
hit a spot where the broken off part is too long.
But with hyphen insertion, that is no longer true,
necessarily. Consider 'bli '. Breaking after 'bl'
will insert 'bl-', which might be longer than
'bli', which is what will be inserted when we
break after the i.
To fix this, keep looking for breakpoints as long
as there is still a chance to find one.
|
|
|
|
|
| |
We always need to check if we still fit, after shaping.
The width we use before is just an estimate.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The key insight here is that if we find a broken item
does not fit, we are only interested in finding an
*earlier* breakpoint - the later ones aren't going
to produce a shorter run.
So we can just keep track of the last char we want
to allow breaking at.
This fixes the case of finding the minimum width
with wrap mode PANGO_WRAP_WORD.
|
| |
|
|
|
|
|
|
|
|
|
| |
We were not passing the correct split_offset to
pango_item_split().
Testcase included.
Fixes: #627
|
| |
|
|
|
|
| |
This keeps spiraling :(
|
|
|
|
|
|
| |
If the break is at the end of the item, we
were forgetting to check for the space before
the break.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When we are breaking after a space, we must not
count the width of the space towards the line,
since we are zeroing it later.
It is a bit annoying that there are multiple places
where this has to be taken into account.
Another missing bit in this code is that we are
only looking at a single whitespace character before
the break, when we should really look for a sequence
of spaces.
|
|
|
|
|
| |
When unsplitting an item, we were sometimes
calculating the remaining_width incorrectly.
|
|
|
|
| |
We can use the log_widths that we already have.
|
|
|
|
|
|
| |
We only want this inside process_item, so we can
make this a purely local thing, without modifying
log_attrs.
|
| |
|
|\
| |
| |
| |
| | |
coretext: correctly clamp the core text weights at min/max values
See merge request GNOME/pango!502
|
| |
| |
| |
| | |
Addresses bug found in #624
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Our accounting for run lengths is imperfect (mainly
due to log widths for clusters being evenly distributed),
so it can happen that after reshaping the split item,
we find that it does not actually fit in the remaining
width. Previously, we would just use the split run
at that point and produce an overlong line. Instead,
undo the split, disable the breakpoint we used, and
try again.
|
| |
| |
| |
| |
| |
| | |
This undoes the effect of pango_item_split.
We will use this in future commits.
Private for now.
|
| |
| |
| |
| | |
This will let us use some of them during layout.
|
| | |
|
|/
|
|
|
| |
In some cases, we were forgetting to account
for the width of a hyphen.
|