| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Skip the host key check only, if the transport actually used
gssapi-keyex. Add tests for the missing-host-key RejectPolicy.
Before this change, a man-in-the-middle attack on the paramiko ssh
client with gss_kex=True was possible by having a server that does not
support gssapi-keyex and gives any or no host key.
|
|\ \ \
| |/ / |
|
| | | |
|
| |\ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
If we have a host keys that will be checked, we need to
negotiate for the type we have. Commonly, openssh could
have saved an ecdsa key in known_hosts, but SSHClient will
let the Transport negotiate for an rsa key.
Then it would consider a key of a non-corresponding type to be "missing".
That situation is also now a BadHostKeyException.
Before this change, a man-in-the-middle attack on the paramiko ssh
client was possible by having only a host key type which differs from
what the client has in known_hosts (and then giving any key of that type).
|
|\ \ \ \
| | |/ /
| |/| | |
|
| |\ \ \
| | |/ /
| |/| /
| | |/ |
|
| | |\ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
It was only recently added, and it's not really needed after the
ResourceManager removal. Removing it allows the SSHClient to be
garbage-collected if only the Transport (and Channels) are still
in use.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The back-reference from Transport to SSHClient was added because
the SSHClient had a destructor that would close the Transport,
and some users did not want the Transport closed when the SSHClient
was garbage collected.
The SSHClient destructor was not a normal destructor, it was
implemented with the ResourceManager singleton. Together with
the back-reference, this prevented the GC cycle detector from
freeing the SSHClient and Transport.
|
| | | | |
|
|\ \ \ \ |
|
| | | | | |
|
| | | | | |
|
| |\ \ \ \
| | |/ / / |
|
| | |\ \ \
| | | | |/
| | | |/| |
|
| | | |/
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Existing just-warnings setup was old and not as rigorous as my usual.
Required a lot of stupid little changes, but now same tooling for all
projects, toot toot.
|
| | |\ \
| | | |/ |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| |\ \ \
| | |/ /
| |/| /
| | |/ |
|
| | | |
|
| | | |
|
| |\ \
| | |/ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In some cases, the SSH client is created, the command is executed, the
streams are extracted, and the explicit reference to SSHClient is then
discarded (since it was e.g. created in a function that only returns the
streams). In this case, the SHSClient may be garbage collected, and the
connection's state is undefined.
This fix adds a reference from Transport to the SSHClient that created
it. The streams have a reference to the Channel, which references the
Transport. Now that the Transport references the SSHClient, it won't be
garbage collected until it is closed.
Closes-Bug: #44
Related-Bug: #344
|
|/ /
| |
| |
| |
| |
| | |
during auth.
This is has been observed with certain windows SSH servers.
|
|\ \
| |/ |
|
| | |
|
| |
| |
| |
| | |
This reverts commit 5c7f30be9737f73fd024a23f5db0b6a7578026b6.
|
|/ |
|
| |
|
|
|
|
| |
Re #398
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The SSH protocol allows the client to transmit environment variables to
the server. This is particularly useful if the user wants to modify the
environment of an executed command without having to reexecute the
actual command from a shell.
This patch extends the Client and Channel interface to allow
the transmission of environment variables to the server side.
In order to use this feature the SSH server must accept environment
variables from the client (e.g. the AcceptEnv configuration directive of
OpenSSH).
FROM BITPROPHET: backport cherry-pick to 1.x line
|
| |
|
|\ |
|
| |
| |
| |
| | |
This trips up lots of users. Re #45
|
| | |
|
|\ \ |
|
| | | |
|
| |\ \
| | |/ |
|
| | |
| | |
| | |
| | | |
(This rolls in patch in #439)
|
| | |
| | |
| | |
| | | |
Re #22
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
Re #22
|
| | | |
|
| | | |
|