summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZuul <zuul@review.openstack.org>2018-03-26 15:54:00 +0000
committerGerrit Code Review <review@openstack.org>2018-03-26 15:54:00 +0000
commit90849ed0796ba0b7f5780c18d0eb99ef9d388431 (patch)
tree5a883106bd6b79bf920e7a1f4d2f8f672573e231
parent7e2d1666f2b494ef4120614e9632ca22adedb8ef (diff)
parent37a1ce7f8529857a718022b250463251b7539dc7 (diff)
downloadpbr-90849ed0796ba0b7f5780c18d0eb99ef9d388431.tar.gz
Merge "update parse test to use reliable comparison"
-rw-r--r--pbr/tests/test_packaging.py17
1 files changed, 15 insertions, 2 deletions
diff --git a/pbr/tests/test_packaging.py b/pbr/tests/test_packaging.py
index da221d7..5512d5d 100644
--- a/pbr/tests/test_packaging.py
+++ b/pbr/tests/test_packaging.py
@@ -884,7 +884,7 @@ class TestRequirementParsing(base.BaseTestCase):
expected_requirements = {
None: ['bar', 'requests-aws>=0.1.4'],
":(python_version=='2.6')": ['quux<1.0'],
- ":(python_version=='2.7')": ['Routes>=1.12.3,!=2.0,!=2.1',
+ ":(python_version=='2.7')": ['Routes!=2.0,!=2.1,>=1.12.3',
'requests-kerberos>=0.6'],
'test': ['foo'],
"test:(python_version=='2.7')": ['baz>3.2', 'bar>3.3']
@@ -903,7 +903,20 @@ class TestRequirementParsing(base.BaseTestCase):
generated_requirements = dict(
pkg_resources.split_sections(requires))
- self.assertEqual(expected_requirements, generated_requirements)
+ # NOTE(dhellmann): We have to spell out the comparison because
+ # the rendering for version specifiers in a range is not
+ # consistent across versions of setuptools.
+
+ for section, expected in expected_requirements.items():
+ exp_parsed = [
+ pkg_resources.Requirement.parse(s)
+ for s in expected
+ ]
+ gen_parsed = [
+ pkg_resources.Requirement.parse(s)
+ for s in generated_requirements[section]
+ ]
+ self.assertEqual(exp_parsed, gen_parsed)
def get_soabi():