summaryrefslogtreecommitdiff
path: root/releasenotes
diff options
context:
space:
mode:
authorStephen Finucane <sfinucan@redhat.com>2017-10-06 15:44:13 +0100
committerStephen Finucane <sfinucan@redhat.com>2017-10-09 10:48:33 +0100
commit32c90ba598d7740e52bf21bc5e920fb5df08645a (patch)
tree3ec86c93f0aa1e5200b2444a22561b516235b75d /releasenotes
parent87637bdf1d22d5e6aee5650b533e477e8e715b19 (diff)
downloadpbr-32c90ba598d7740e52bf21bc5e920fb5df08645a.tar.gz
Remove support for command hooks
distutils2 is long dead and many of its best ideas have been incorporated into setuptools. One of the ideas that *has not* been incorporated is the idea of command hooks, of either the pre or post kind. pbr is still carrying the code for this, and there are several issues with this: - No one is using this functionality in OpenStack and, given the complete lack of documentation on the matter, it's very doubtful that it's being used anywhere else [1] - It's causing issues for projects attempting to hook into the 'distutils.commands' entry point on Python 2.7, which it seems no else must have attempted yet [2]. - distutils2 is dead and advanced features like this that we don't explicitly need should not be retained We could attempt to fix this but why bother? Good riddance, I say. [1] http://codesearch.openstack.org/?q=pre_hook%5C.&i=nope&files=&repos= [2] http://codesearch.openstack.org/?q=distutils.commands&i=nope&files=&repos= Change-Id: I01f657034cffbf55ce830b7e8dbb6b3d94c1fd18
Diffstat (limited to 'releasenotes')
-rw-r--r--releasenotes/notes/remove-command-hooks-907d9c2325f306ca.yaml6
1 files changed, 6 insertions, 0 deletions
diff --git a/releasenotes/notes/remove-command-hooks-907d9c2325f306ca.yaml b/releasenotes/notes/remove-command-hooks-907d9c2325f306ca.yaml
new file mode 100644
index 0000000..c6ce753
--- /dev/null
+++ b/releasenotes/notes/remove-command-hooks-907d9c2325f306ca.yaml
@@ -0,0 +1,6 @@
+---
+upgrade:
+ - |
+ Support for entry point command hooks has been removed. This feature was
+ poorly tested, poorly documented, and broken in some environments.
+ Support for global hooks is not affected.