diff options
| author | Nicholas Clark <nick@ccl4.org> | 2021-09-20 11:17:40 +0000 |
|---|---|---|
| committer | Nicholas Clark <nick@ccl4.org> | 2021-09-26 08:51:18 +0000 |
| commit | f3589814ab7492ea2605bc780a72c9b3b8d521c0 (patch) | |
| tree | a05b8d42962bc0dd563e4265ab96d76143ddb7b9 /.github | |
| parent | 642e41bdcfaa9393a94d533f938b9ea35d23dcf7 (diff) | |
| download | perl-f3589814ab7492ea2605bc780a72c9b3b8d521c0.tar.gz | |
Change all LD_LIBRARY_PATH setup from '.' to `pwd`
The previous commit added various new lines that set LD_LIBRARY_PATH=`pwd`,
whereas the existing lines that set LD_LIBRARY_PATH set it to '.'.
LD_LIBRARY_PATH needs to be set to the build directory to run an uninstalled
perl binary *if* that binary is built with a shared perl library. It's not
needed for the default configuration, but to simplify the test definitions we
were doing it always.
In turn, LD_LIBRARY_PATH doesn't need to be set to an *absolute* path if all
that is invoked is the perl binary - it doesn't change directory, and it
does shell out to itself, hence setting LD_LIBRARY_PATH=. is just fine here.
Running the regression tests *does* involve changing directory before
invoking perl, so LD_LIBRARY_PATH needs to be set to an absolute path there.
Running `./perl -Ilib -V` doesn't change directory (or shell out) so '.'
was good enough.
There's no real harm in also invoking `pwd` to get an absolute path here, so
do this instead of just coding '.', as the consistency makes the workflow
easier to read - you don't get distracted wondering "Why are these
different, and is that a bug?"
Diffstat (limited to '.github')
| -rw-r--r-- | .github/workflows/testsuite.yml | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/.github/workflows/testsuite.yml b/.github/workflows/testsuite.yml index ede416f35f..3b25c07fd1 100644 --- a/.github/workflows/testsuite.yml +++ b/.github/workflows/testsuite.yml @@ -154,8 +154,8 @@ jobs: MALLOC_PERTURB_=254 MALLOC_CHECK_=3 make -j2 test_prep - name: Show Config run: | - LD_LIBRARY_PATH=. ./perl -Ilib -V - LD_LIBRARY_PATH=. ./perl -Ilib -e 'use Config; print Config::config_sh' + LD_LIBRARY_PATH=`pwd` ./perl -Ilib -V + LD_LIBRARY_PATH=`pwd` ./perl -Ilib -e 'use Config; print Config::config_sh' - name: Run Tests run: | LD_LIBRARY_PATH=`pwd` MALLOC_PERTURB_=254 MALLOC_CHECK_=3 TEST_JOBS=2 ./perl t/harness @@ -205,8 +205,8 @@ jobs: MALLOC_PERTURB_=254 MALLOC_CHECK_=3 make -j2 - name: Show Config run: | - LD_LIBRARY_PATH=. ./perl -Ilib -V - LD_LIBRARY_PATH=. ./perl -Ilib -e 'use Config; print Config::config_sh' + LD_LIBRARY_PATH=`pwd` ./perl -Ilib -V + LD_LIBRARY_PATH=`pwd` ./perl -Ilib -e 'use Config; print Config::config_sh' # Leaving this as `make test` so that we test the `test` target on regular # Linux. # linux-i386 is just one job (not a matrix) @@ -242,8 +242,8 @@ jobs: MALLOC_PERTURB_=254 MALLOC_CHECK_=3 make -j2 - name: Show Config run: | - LD_LIBRARY_PATH=. ./perl -Ilib -V - LD_LIBRARY_PATH=. ./perl -Ilib -e 'use Config; print Config::config_sh' + LD_LIBRARY_PATH=`pwd` ./perl -Ilib -V + LD_LIBRARY_PATH=`pwd` ./perl -Ilib -e 'use Config; print Config::config_sh' - name: Run Tests run: | MALLOC_PERTURB_=254 MALLOC_CHECK_=3 TEST_JOBS=2 make -j2 test_harness |