diff options
| author | M. J. T. Guy <mjtg@cus.cam.ac.uk> | 1998-07-15 13:41:14 +0100 |
|---|---|---|
| committer | Gurusamy Sarathy <gsar@cpan.org> | 1998-07-19 06:23:10 +0000 |
| commit | 8202fd39354c88c225e4200fee9877f5a082eebe (patch) | |
| tree | 19b891ade5f952ca5edffd3fe1e42d49e8d637f2 | |
| parent | 8c5191c6cf56d6872d0b360ee91c299e861f844a (diff) | |
| download | perl-8202fd39354c88c225e4200fee9877f5a082eebe.tar.gz | |
minor re.pm cleanup
Message-Id: <E0ywPvu-0003V7-00@ursa.cus.cam.ac.uk>
Subject: Re: [PATCH 5.004_74]Don't use tainted REs in Basename.pm when building perl
p4raw-id: //depot/perl@1550
| -rw-r--r-- | ext/re/re.pm | 8 | ||||
| -rw-r--r-- | pod/perldiag.pod | 4 |
2 files changed, 7 insertions, 5 deletions
diff --git a/ext/re/re.pm b/ext/re/re.pm index 8b49ca14f4..4a44753172 100644 --- a/ext/re/re.pm +++ b/ext/re/re.pm @@ -81,11 +81,9 @@ sub bits { } foreach my $s (@_){ if ($s eq 'debug') { - eval <<'EOE'; - use DynaLoader; - @ISA = ('DynaLoader'); - bootstrap re; -EOE + require DynaLoader; + @ISA = ('DynaLoader'); + bootstrap re; install() if $on; uninstall() unless $on; next; diff --git a/pod/perldiag.pod b/pod/perldiag.pod index b87480e4c8..43226e076d 100644 --- a/pod/perldiag.pod +++ b/pod/perldiag.pod @@ -2845,6 +2845,10 @@ bad side effects. interpreted as a "" or a 0, but maybe it was a mistake. To suppress this warning assign an initial value to your variables. +=item Useless use of "re" pragma + +(W) You did C<use re;> without any arguments. That isn't very useful. + =item Useless use of %s in void context (W) You did something without a side effect in a context that does nothing |