diff options
| author | Jim Cromie <jim.cromie@gmail.com> | 2011-05-31 10:47:29 -0600 |
|---|---|---|
| committer | Father Chrysostomos <sprout@cpan.org> | 2011-06-01 06:35:08 -0700 |
| commit | 5c70016eb3bb7b430ef912d422b3d2727c118336 (patch) | |
| tree | 7f5a7779ce057fc844a5bb872426023e363bba4e | |
| parent | 4c62848cee9456381b8a92efa826fae945787048 (diff) | |
| download | perl-5c70016eb3bb7b430ef912d422b3d2727c118336.tar.gz | |
perlhack.pod: invoke git-format-patch with --attach
As George Greer noted on p5p, --attach causes the message to be
written using MIME-attach syntax, so when perlbug sends it,
rt.perl.org detaches the file and adds it to the ticket.
While tradtional inline patches appear to survive without whitespace
mangling, attachments are more in keeping with RTs design and use.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
| -rw-r--r-- | pod/perlhack.pod | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/pod/perlhack.pod b/pod/perlhack.pod index f8f8bdd82c..6f5ea7371b 100644 --- a/pod/perlhack.pod +++ b/pod/perlhack.pod @@ -56,10 +56,11 @@ sentence. For example, "Fixed spelling errors in perlhack.pod". The next step is to submit your patch to the Perl core ticket system via email. -Assuming your patch consists of a single git commit, you can send it to -perlbug with this command line: +Assuming your patch consists of a single git commit, the following +writes the file as a MIME attachment, and sends it with a meaningful +subject: - % git format-patch -1 + % git format-patch -1 --attach % perlbug -s "[PATCH] $(git log -1 --oneline HEAD)" -f 0001-*.patch The perlbug program will ask you a few questions about your email |