diff options
author | Father Chrysostomos <sprout@cpan.org> | 2011-11-27 18:37:14 -0800 |
---|---|---|
committer | Father Chrysostomos <sprout@cpan.org> | 2011-11-27 18:37:14 -0800 |
commit | ce2077b184ce12e83580ca1d9686e4af75dc538a (patch) | |
tree | 44aa32c83fe33b8b5af5f990e6e10d733d770600 | |
parent | fea3622c948af84617d7c45cbbeb8ce76b59cad3 (diff) | |
download | perl-ce2077b184ce12e83580ca1d9686e4af75dc538a.tar.gz |
sv.c: Turn a FIXME comment into an explanation
-rw-r--r-- | sv.c | 6 |
1 files changed, 3 insertions, 3 deletions
@@ -3645,8 +3645,8 @@ S_glob_assign_glob(pTHX_ SV *const dstr, SV *const sstr, const int dtype) } SvUPGRADE(dstr, SVt_PVGV); (void)SvOK_off(dstr); - /* FIXME - why are we doing this, then turning it off and on again - below? */ + /* We have to turn this on here (even though we turn it off + below, as GvSTASH will fail an assertion otherwise. */ isGV_with_GP_on(dstr); } GvSTASH(dstr) = GvSTASH(sstr); @@ -3711,7 +3711,7 @@ S_glob_assign_glob(pTHX_ SV *const dstr, SV *const sstr, const int dtype) } gp_free(MUTABLE_GV(dstr)); - isGV_with_GP_off(dstr); + isGV_with_GP_off(dstr); /* SvOK_off does not like globs. */ (void)SvOK_off(dstr); isGV_with_GP_on(dstr); GvINTRO_off(dstr); /* one-shot flag */ |