summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRafael Garcia-Suarez <rgs@consttype.org>2010-01-15 17:37:36 +0100
committerRafael Garcia-Suarez <rgs@consttype.org>2010-01-15 17:40:20 +0100
commit1bb5f2059539b5573bb73de8c3a235284687220b (patch)
tree6640910ec9a77030334ccab2e397b3ba470695c4
parentaf61dbfdfb97af17b1150478d07da724cd530424 (diff)
downloadperl-1bb5f2059539b5573bb73de8c3a235284687220b.tar.gz
The warnings emitted by PerlIO::encoding should be silenceable.
Make them mandatory warnings.
-rw-r--r--ext/PerlIO-encoding/encoding.xs13
1 files changed, 8 insertions, 5 deletions
diff --git a/ext/PerlIO-encoding/encoding.xs b/ext/PerlIO-encoding/encoding.xs
index dc6981979c..2d515b6540 100644
--- a/ext/PerlIO-encoding/encoding.xs
+++ b/ext/PerlIO-encoding/encoding.xs
@@ -108,8 +108,9 @@ PerlIOEncode_pushed(pTHX_ PerlIO * f, const char *mode, SV * arg, PerlIO_funcs *
if (!SvROK(result) || !SvOBJECT(SvRV(result))) {
e->enc = Nullsv;
- Perl_warner(aTHX_ packWARN(WARN_IO), "Cannot find encoding \"%" SVf "\"",
- arg);
+ if (ckWARN_d(WARN_IO))
+ Perl_warner(aTHX_ packWARN(WARN_IO), "Cannot find encoding \"%" SVf "\"",
+ arg);
errno = EINVAL;
code = -1;
}
@@ -120,8 +121,9 @@ PerlIOEncode_pushed(pTHX_ PerlIO * f, const char *mode, SV * arg, PerlIO_funcs *
XPUSHs(result);
PUTBACK;
if (call_method("renew",G_SCALAR|G_EVAL) != 1 || SvTRUE(ERRSV)) {
- Perl_warner(aTHX_ packWARN(WARN_IO), "\"%" SVf "\" does not support renew method",
- arg);
+ if (ckWARN_d(WARN_IO))
+ Perl_warner(aTHX_ packWARN(WARN_IO), "\"%" SVf "\" does not support renew method",
+ arg);
}
else {
SPAGAIN;
@@ -133,7 +135,8 @@ PerlIOEncode_pushed(pTHX_ PerlIO * f, const char *mode, SV * arg, PerlIO_funcs *
XPUSHs(e->enc);
PUTBACK;
if (call_method("needs_lines",G_SCALAR|G_EVAL) != 1 || SvTRUE(ERRSV)) {
- Perl_warner(aTHX_ packWARN(WARN_IO), "\"%" SVf "\" does not support needs_lines",
+ if (ckWARN_d(WARN_IO))
+ Perl_warner(aTHX_ packWARN(WARN_IO), "\"%" SVf "\" does not support needs_lines",
arg);
}
else {