summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGisle Aas <gisle@aas.no>2010-04-18 17:12:24 +0200
committerGisle Aas <gisle@aas.no>2010-04-18 17:22:45 +0200
commitcf14ed9bd246c76a9423a702a266c104120d0ae9 (patch)
tree437783bb029c9d048e2c9c0304daa692b1d189ba
parentabe97ede60e530226f7420f5de75584e0c7e0565 (diff)
downloadperl-cf14ed9bd246c76a9423a702a266c104120d0ae9.tar.gz
Avoid "Use of uninitialized value $base" for the CPANPLUS .hidden file
-rw-r--r--Porting/check83.pl5
1 files changed, 4 insertions, 1 deletions
diff --git a/Porting/check83.pl b/Porting/check83.pl
index 56989fa9e0..1bd863f46e 100644
--- a/Porting/check83.pl
+++ b/Porting/check83.pl
@@ -20,13 +20,16 @@ my $maxl = 30; # make up a limit for a maximum filename length
sub eight_dot_three {
return () if $seen{$_[0]}++;
- my ($dir, $base, $ext) = ($_[0] =~ m{^(?:(.+)/)?([^/.]+)(?:\.([^/.]+))?$});
+ my ($dir, $base, $ext) = ($_[0] =~ m{^(?:(.+)/)?([^/.]*)(?:\.([^/.]+))?$});
my $file = $base . ( defined $ext ? ".$ext" : "" );
$base = substr($base, 0, 8);
$ext = substr($ext, 0, 3) if defined $ext;
if (defined $dir && $dir =~ /\./) {
print "directory name contains '.': $dir\n";
}
+ if ($base eq "") {
+ print "filename starts with dot: $_[0]\n";
+ }
if ($file =~ /[^A-Za-z0-9\._-]/) {
print "filename contains non-portable characters: $_[0]\n";
}