diff options
| author | Father Chrysostomos <sprout@cpan.org> | 2011-08-12 12:29:07 -0700 |
|---|---|---|
| committer | Father Chrysostomos <sprout@cpan.org> | 2011-08-14 06:38:21 -0700 |
| commit | 7391a1634af9fc4c03048f12594b25fd776ccf98 (patch) | |
| tree | c55520e672647f91b6160a7e5c767f7e8337cc22 | |
| parent | 987f272968e350efe632beb4980144f7c020a05d (diff) | |
| download | perl-7391a1634af9fc4c03048f12594b25fd776ccf98.tar.gz | |
Remove select’s prototype
select has a prototype of (;*), which is incorrect, as it implied that
it has high precedence. It also fails to account for the four-argu-
ment form. While removing all incorrect prototypes is counterproduc-
tive, I think this one is wrong enough it deserves to go. (And the
precedence problem is a good argument against it, as there is cur-
rently no other way to set precedence.)
| -rw-r--r-- | dist/B-Deparse/Deparse.pm | 4 | ||||
| -rw-r--r-- | op.c | 2 | ||||
| -rw-r--r-- | t/op/cproto.t | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/dist/B-Deparse/Deparse.pm b/dist/B-Deparse/Deparse.pm index 848b2fa7a3..cb60bae653 100644 --- a/dist/B-Deparse/Deparse.pm +++ b/dist/B-Deparse/Deparse.pm @@ -26,7 +26,7 @@ use B qw(class main_root main_start main_cv svref_2object opnumber perlstring ($] < 5.009 ? 'PMf_SKIPWHITE' : qw(RXf_SKIPWHITE)), ($] < 5.011 ? 'CVf_LOCKED' : 'OPpREVERSE_INPLACE'), ($] < 5.013 ? () : 'PMf_NONDESTRUCT'); -$VERSION = "1.06"; +$VERSION = "1.07"; use strict; use vars qw/$AUTOLOAD/; use warnings (); @@ -1553,7 +1553,7 @@ sub keyword { : "CORE::$name"; } if ( - $name !~ /^(?:chom?p|exec|system)\z/ + $name !~ /^(?:chom?p|exec|s(?:elect|ystem))\z/ && !defined eval{prototype "CORE::$name"} ) { return $name } if ( @@ -10283,7 +10283,7 @@ Perl_core_prototype(pTHX_ SV *sv, const char *name, const STRLEN len, case KEY_cmp : case KEY_exec: case KEY_eq : case KEY_ge : case KEY_gt : case KEY_le : case KEY_lt : case KEY_ne : case KEY_or : - case KEY_system: case KEY_x : case KEY_xor : + case KEY_select: case KEY_system: case KEY_x : case KEY_xor: return NULL; case KEY_keys: case KEY_values: case KEY_each: retsetpvs("+"); diff --git a/t/op/cproto.t b/t/op/cproto.t index 9711f824ae..1476ae6ab4 100644 --- a/t/op/cproto.t +++ b/t/op/cproto.t @@ -197,7 +197,7 @@ say undef scalar undef seek (*$$) seekdir (*$) -select (;*) +select undef semctl ($$$$) semget ($$$) semop ($$) |