diff options
author | Nicholas Clark <nick@ccl4.org> | 2006-10-18 19:11:55 +0000 |
---|---|---|
committer | Nicholas Clark <nick@ccl4.org> | 2006-10-18 19:11:55 +0000 |
commit | 00e0e810c1b6ec448029dccbfb10081759cf8705 (patch) | |
tree | 0131eca81ee65ad5c912770b24fbcf9dcd826c5e | |
parent | 8c28b960db3547273cd8c89c0eaafc8e99cf70c1 (diff) | |
download | perl-00e0e810c1b6ec448029dccbfb10081759cf8705.tar.gz |
Using explicit printf-like APIs with a format of "%s" isn't the world's
most efficient idea.
p4raw-id: //depot/perl@29042
-rw-r--r-- | XSUB.h | 2 | ||||
-rw-r--r-- | dump.c | 4 |
2 files changed, 3 insertions, 3 deletions
@@ -295,7 +295,7 @@ Rethrows a previously caught exception. See L<perlguts/"Exception Handling">. vn = "VERSION"), FALSE); \ } \ if (_sv) { \ - SV *xssv = Perl_newSVpvf(aTHX_ "%s",XS_VERSION); \ + SV *xssv = Perl_newSVpv(aTHX_ XS_VERSION, 0); \ xssv = new_version(xssv); \ if ( !sv_derived_from(_sv, "version") ) \ _sv = new_version(_sv); \ @@ -280,12 +280,12 @@ Perl_pv_pretty( pTHX_ SV *dsv, char const * const str, const STRLEN count, sv_setpvn(dsv, "", 0); if ( start_color != NULL ) - Perl_sv_catpvf( aTHX_ dsv, "%s", start_color); + Perl_sv_catpv( aTHX_ dsv, start_color); pv_escape( dsv, str, count, max, &escaped, flags | PERL_PV_ESCAPE_NOCLEAR ); if ( end_color != NULL ) - Perl_sv_catpvf( aTHX_ dsv, "%s", end_color); + Perl_sv_catpv( aTHX_ dsv, end_color); if ( dq == '"' ) sv_catpvn( dsv, "\"", 1 ); |