summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKarl Williamson <public@khwilliamson.com>2012-04-18 15:25:28 -0600
committerKarl Williamson <public@khwilliamson.com>2012-04-26 11:58:56 -0600
commit0447e8df3db3f566f76a613f62c5f4cdd7262997 (patch)
treefda9e9e14099a7ee147911071f95dd001bcaa3d1
parent0ae1fa71a437dfa435b139674610ec992366d661 (diff)
downloadperl-0447e8df3db3f566f76a613f62c5f4cdd7262997.tar.gz
utf8.h: Use correct definition of start byte
The previous definition allowed for (illegal) overlongs. The uses of this macro in the core assume that it is accurate. The inacurracy can cause such code to fail.
-rw-r--r--utf8.h4
-rw-r--r--utfebcdic.h3
2 files changed, 3 insertions, 4 deletions
diff --git a/utf8.h b/utf8.h
index 152a937f54..06418d6800 100644
--- a/utf8.h
+++ b/utf8.h
@@ -139,9 +139,7 @@ Perl's extended UTF-8 means we can have start bytes up to FF.
*/
#define UNI_IS_INVARIANT(c) (((UV)c) < 0x80)
-/* Note that C0 and C1 are invalid in legal UTF8, so the lower bound of the
- * below might ought to be C2 */
-#define UTF8_IS_START(c) (((U8)c) >= 0xc0)
+#define UTF8_IS_START(c) (((U8)c) >= 0xc2)
#define UTF8_IS_CONTINUATION(c) (((U8)c) >= 0x80 && (((U8)c) <= 0xbf))
#define UTF8_IS_CONTINUED(c) (((U8)c) & 0x80)
diff --git a/utfebcdic.h b/utfebcdic.h
index b3b767df26..eff444e7fd 100644
--- a/utfebcdic.h
+++ b/utfebcdic.h
@@ -584,7 +584,8 @@ END_EXTERN_C
#define UNI_IS_INVARIANT(c) ((c) < 0xA0)
/* UTF-EBCDIC semantic macros - transform back into I8 and then compare */
-#define UTF8_IS_START(c) (NATIVE_TO_UTF(c) >= 0xA0 && (NATIVE_TO_UTF(c) & 0xE0) != 0xA0)
+
+#define UTF8_IS_START(c) (NATIVE_TO_UTF(c) >= 0xC5 && NATIVE_TO_UTF(c) != 0xE0)
#define UTF8_IS_CONTINUATION(c) ((NATIVE_TO_UTF(c) & 0xE0) == 0xA0)
#define UTF8_IS_CONTINUED(c) (NATIVE_TO_UTF(c) >= 0xA0)
#define UTF8_IS_DOWNGRADEABLE_START(c) (NATIVE_TO_UTF(c) >= 0xC5 && NATIVE_TO_UTF(c) <= 0xC7)