diff options
author | Vincent Pit <vince@profvince.com> | 2009-11-05 21:55:35 +0100 |
---|---|---|
committer | Vincent Pit <vince@profvince.com> | 2009-11-05 21:55:35 +0100 |
commit | cb39f75f02caa9f23c14dfcac8a46fb1bd154b4f (patch) | |
tree | 92de67be7aa5df0102d523dd5ce2509584a30d5d | |
parent | 6f5be6d1e57649daa9cd098564878b601d687e77 (diff) | |
download | perl-cb39f75f02caa9f23c14dfcac8a46fb1bd154b4f.tar.gz |
SvREFCNT_dec already checks if the SV is non-NULL
-rw-r--r-- | doop.c | 3 | ||||
-rw-r--r-- | pp.c | 9 |
2 files changed, 4 insertions, 8 deletions
@@ -1467,8 +1467,7 @@ Perl_do_kv(pTHX) } LvTYPE(TARG) = 'k'; if (LvTARG(TARG) != (const SV *)keys) { - if (LvTARG(TARG)) - SvREFCNT_dec(LvTARG(TARG)); + SvREFCNT_dec(LvTARG(TARG)); LvTARG(TARG) = SvREFCNT_inc_simple(keys); } PUSHs(TARG); @@ -349,8 +349,7 @@ PP(pp_pos) LvTYPE(TARG) = '.'; if (LvTARG(TARG) != sv) { - if (LvTARG(TARG)) - SvREFCNT_dec(LvTARG(TARG)); + SvREFCNT_dec(LvTARG(TARG)); LvTARG(TARG) = SvREFCNT_inc_simple(sv); } PUSHs(TARG); /* no SvSETMAGIC */ @@ -3226,8 +3225,7 @@ PP(pp_substr) LvTYPE(TARG) = 'x'; if (LvTARG(TARG) != sv) { - if (LvTARG(TARG)) - SvREFCNT_dec(LvTARG(TARG)); + SvREFCNT_dec(LvTARG(TARG)); LvTARG(TARG) = SvREFCNT_inc_simple(sv); } LvTARGOFF(TARG) = upos; @@ -3257,8 +3255,7 @@ PP(pp_vec) } LvTYPE(TARG) = 'v'; if (LvTARG(TARG) != src) { - if (LvTARG(TARG)) - SvREFCNT_dec(LvTARG(TARG)); + SvREFCNT_dec(LvTARG(TARG)); LvTARG(TARG) = SvREFCNT_inc_simple(src); } LvTARGOFF(TARG) = offset; |