regen/mph.pl - convert loop to use block form and add comment

Using the comma operator to separate statments is fine on a one liner,
but so much in a script that is part of perl regen processes. IMO.

1 files changed, 8 insertions, 2 deletions

diff --git a/regen/mph.pl b/regen/mph.pl
index 577563011d..79d3ee2989 100644
--- a/regen/mph.pl
+++ b/regen/mph.pl
@@ -129,10 +129,16 @@ sub build_perfect_hash {
             } @$keys;
             last;
         }
+    }
 
+    # now that we are done we can go through and fill in the idx and
+    # seed2 as appropriate. We store idx into the hashes even though it
+    # is not stricly necessary as it simplifies some of the code that
+    # processes the \@second_level array later.
+    foreach my $idx (0 .. $n - 1) {
+        $second_level[$idx]{seed2}= $first_level[$idx] || 0;
+        $second_level[$idx]{idx}= $idx;
     }
-    $second_level[$_]{seed2}= $first_level[$_] || 0, $second_level[$_]{idx}= $_
-        for 0 .. $#second_level;
 
     return $seed1, \@second_level;
 }