diff options
| author | Father Chrysostomos <sprout@cpan.org> | 2011-10-15 14:05:33 -0700 |
|---|---|---|
| committer | Father Chrysostomos <sprout@cpan.org> | 2011-10-15 14:24:27 -0700 |
| commit | 2fc49ef14c391f64250e0f99fbbed2007b880289 (patch) | |
| tree | 09a7cf04ca5912c7f2c2dec482ff0d5638f8e51b /MANIFEST | |
| parent | 67ecba2f90752611c774e73ef7ad292d8d4a03c9 (diff) | |
| download | perl-2fc49ef14c391f64250e0f99fbbed2007b880289.tar.gz | |
Make XS sort routines work again
These stopped working when the CvROOT and CvXSUB fields were merged
in 5.10.0:
$ perl5.8.9 -le 'print sort utf8::is_utf8 2,1'
Usage: utf8::is_utf8(sv) at -e line 1.
$ perl5.10.0 -le 'print sort utf8::is_utf8 2,1'
12
(In the latter case, the utf8::is_utf8 routine is not being called.)
pp_sort has this:
if (!(cv && CvROOT(cv))) {
if (cv && CvISXSUB(cv)) {
But CvROOT is the same as CvXSUB, so that block is never entered for
XSUBs, so this piece of code later on:
if (is_xsub)
PL_sortcop = (OP*)cv;
else
PL_sortcop = CvSTART(cv);
sets PL_sortcop to CvSTART for XSUBs, but CvSTART is NULL. Later on,
this if condition fails:
if (PL_sortcop) {
so the XSUB is treated as being absent.
Diffstat (limited to 'MANIFEST')
| -rw-r--r-- | MANIFEST | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -3867,6 +3867,7 @@ ext/XS-APItest/t/rmagical.t XS::APItest extension ext/XS-APItest/t/rv2cv_op_cv.t test rv2cv_op_cv() API ext/XS-APItest/t/savehints.t test SAVEHINTS() API ext/XS-APItest/t/scopelessblock.t test recursive descent statement-sequence parsing +ext/XS-APItest/t/sort.t Test sort(xs_cmp ...) ext/XS-APItest/t/stmtasexpr.t test recursive descent statement parsing ext/XS-APItest/t/stmtsasexpr.t test recursive descent statement-sequence parsing ext/XS-APItest/t/stuff_modify_bug.t test for eval side-effecting source string |