diff options
author | James E Keenan <jkeenan@cpan.org> | 2020-01-31 03:23:18 +0000 |
---|---|---|
committer | James E Keenan <jkeenan@cpan.org> | 2020-02-04 09:27:50 -0500 |
commit | 2b689a479128e6b86e3d180f70dcf1b447caf0e6 (patch) | |
tree | e78a49c26809ce7cd5da137d78d345f47788c500 /Makefile.SH | |
parent | 915b794bfdc480ffedc696439aa063ae4191d5e3 (diff) | |
download | perl-2b689a479128e6b86e3d180f70dcf1b447caf0e6.tar.gz |
Do not ignore non-zero error code from 'make minitest'
In pipelines like:
$ sh ./Configure -des -Dusedevel && \
make minitest && make test_harness
... we don't want to run 'make test_harness' unless 'make minitest' has
succeeded.
To test:
$ echo "exit(1);" >> t/base/cond.t
$ make minitest && echo "hello world"
# [note that minitest fails quickly and 'echo' is not reached]
$ git checkout -- t/base/cond.t
$ make minitest && echo "hello world"
# [note that minitest runs and 'echo' is reached]
For: https://github.com/perl/perl5/issues/16160
Originally: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=132139
Diffstat (limited to 'Makefile.SH')
-rwxr-xr-x | Makefile.SH | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/Makefile.SH b/Makefile.SH index 6bfe092acd..cab91f7e04 100755 --- a/Makefile.SH +++ b/Makefile.SH @@ -1657,15 +1657,15 @@ minitest_prep: @echo "You may see some irrelevant test failures if you have been unable" @echo "to build lib/Config.pm, or the Unicode data files." @echo " " - - cd t && (rm -f $(PERL_EXE); $(LNS) ../$(MINIPERL_EXE) $(PERL_EXE)) + cd t && (rm -f $(PERL_EXE); $(LNS) ../$(MINIPERL_EXE) $(PERL_EXE)) MINITEST_TESTS = base/*.t comp/*.t cmd/*.t run/*.t io/*.t re/*.t opbasic/*.t op/*.t uni/*.t perf/*.t minitest: $(MINIPERL_EXE) minitest_prep - - cd t && $(RUN_PERL) TEST $(MINITEST_TESTS) <$(devtty) + cd t && $(RUN_PERL) TEST $(MINITEST_TESTS) <$(devtty) minitest-notty minitest_notty: $(MINIPERL_EXE) minitest_prep - - cd t && PERL_SKIP_TTY_TEST=1 $(RUN_PERL) TEST $(MINITEST_TESTS) + cd t && PERL_SKIP_TTY_TEST=1 $(RUN_PERL) TEST $(MINITEST_TESTS) # Test via harness |