diff options
author | Nicholas Clark <nick@ccl4.org> | 2008-02-02 17:01:43 +0000 |
---|---|---|
committer | Nicholas Clark <nick@ccl4.org> | 2008-02-02 17:01:43 +0000 |
commit | 357244ac7b8824046a2f6fdab432230dbbd8cadd (patch) | |
tree | 85800526da64ce1065e74543fbe74f7f0fa8ac2a /Porting/Maintainers.pm | |
parent | 92e45a3e6a37177cdf8021650cda6bd5a43fdbdf (diff) | |
download | perl-357244ac7b8824046a2f6fdab432230dbbd8cadd.tar.gz |
Remove the _ prototype, as Maintainers is used by makemeta, and in turn
that has to be run with the newly built perl. Which can be 5.8.x.
p4raw-id: //depot/perl@33193
Diffstat (limited to 'Porting/Maintainers.pm')
-rw-r--r-- | Porting/Maintainers.pm | 19 |
1 files changed, 11 insertions, 8 deletions
diff --git a/Porting/Maintainers.pm b/Porting/Maintainers.pm index e876f8cba6..4f50e94044 100644 --- a/Porting/Maintainers.pm +++ b/Porting/Maintainers.pm @@ -7,7 +7,9 @@ package Maintainers; use strict; use lib "Porting"; -use 5.010; +# Please don't use post 5.008 features as this module is used by +# Porting/makemeta, and that in turn has to be run by the perl just built. +use 5.008; require "Maintainers.pl"; use vars qw(%Modules %Maintainers); @@ -249,7 +251,6 @@ sub show_results { } } -sub warn_maintainer(_); my %files; sub maintainers_files { @@ -270,19 +271,21 @@ sub duplicated_maintainers { } } +sub warn_maintainer { + my $name = shift; + warn "File $name has no maintainer\n" if not $files{$name}; +} + sub missing_maintainers { my($check, @path) = @_; maintainers_files(); my @dir; - for (@path) { if( -d ) { push @dir, $_ } else { warn_maintainer() } } + for my $d (@path) { + if( -d $d ) { push @dir, $d } else { warn_maintainer($d) } + } find sub { warn_maintainer($File::Find::name) if /$check/; }, @dir if @dir; } -sub warn_maintainer(_) { - my $name = shift; - warn "File $name has no maintainer\n" if not $files{$name}; -} - 1; |