Change get_pod_metadata() to take a callback to report consistency errors.

Using the callback to report errors instead of passing the 'inconsistent'
arrayref back in the state means that get_pod_metadata() doesn't even need
to calculate this information if it's not going to be used.

1 files changed, 5 insertions, 1 deletions

diff --git a/Porting/pod_lib.pl b/Porting/pod_lib.pl
index 3676953db6..b9a9ef7795 100644
--- a/Porting/pod_lib.pl
+++ b/Porting/pod_lib.pl
@@ -50,6 +50,8 @@ sub is_duplicate_pod {
 sub get_pod_metadata {
     # Do we expect to find generated pods on disk?
     my $permit_missing_generated = shift;
+    # Do they want a consistency report?
+    my $callback = shift;
     my %BuildFiles;
 
     foreach my $path (@_) {
@@ -146,6 +148,8 @@ sub get_pod_metadata {
     }
     close $master or my_die "close pod.lst: $!";
 
+    return \%state unless $callback;
+
     # Sanity cross check
 
     my (%disk_pods, %manipods, %manireadmes, %perlpods);
@@ -245,7 +249,7 @@ sub get_pod_metadata {
                     or $not_yet_there{$i};
         }
     }
-    $state{inconsistent} = \@inconsistent;
+    &$callback(@inconsistent);
     return \%state;
 }