summaryrefslogtreecommitdiff
path: root/Porting
diff options
context:
space:
mode:
authorGisle Aas <gisle@aas.no>2010-04-18 17:13:46 +0200
committerGisle Aas <gisle@aas.no>2010-04-18 17:22:45 +0200
commit6348b76e16558421dd8599cc147a5c7f13fddbb9 (patch)
tree9cdc89d7c5d87b6c223d7aba93b05e0cbf45175c /Porting
parentcf14ed9bd246c76a9423a702a266c104120d0ae9 (diff)
downloadperl-6348b76e16558421dd8599cc147a5c7f13fddbb9.tar.gz
Passing regexp vars as argument is unsafe
In this case $_[0] is unexpectedly modified by matching a regular expression inside the function, making it report bad file names.
Diffstat (limited to 'Porting')
-rw-r--r--Porting/check83.pl2
1 files changed, 1 insertions, 1 deletions
diff --git a/Porting/check83.pl b/Porting/check83.pl
index 1bd863f46e..64eac95b89 100644
--- a/Porting/check83.pl
+++ b/Porting/check83.pl
@@ -62,7 +62,7 @@ if (open(MANIFEST, "MANIFEST")) {
next;
}
while (m!/|\z!g) {
- my ($dir, $edt) = eight_dot_three($`);
+ my ($dir, $edt) = eight_dot_three("$`");
next unless defined $dir;
($dir, $edt) = map { lc } ($dir, $edt);
push @{$dir{$dir}->{$edt}}, $_;