diff options
author | Nicholas Clark <nick@ccl4.org> | 2011-04-12 09:01:48 +0100 |
---|---|---|
committer | Nicholas Clark <nick@ccl4.org> | 2011-04-13 14:56:33 +0100 |
commit | 6359c64336d99060952232e7e300bd3c31afead8 (patch) | |
tree | 05293c856aa090ab9fdc4b1bfdfd939b877cf985 /cpan | |
parent | da0c0b273c42c8a3f17664cdbe99318311f652af (diff) | |
download | perl-6359c64336d99060952232e7e300bd3c31afead8.tar.gz |
In testargs.t in Test::Harness, don't run a world-writable file.
The test writes a file, then changes the mode, then executes it. The file needs
to be +x to be executable (on many platforms). The file will need to be +w to
be deletable on some platforms. But setting the file world writable just before
running it feels like a bad idea, given that the file's name is as predictable
as process IDs, as there's a race condition to break into the account running
perl's tests.
Diffstat (limited to 'cpan')
-rw-r--r-- | cpan/Test-Harness/t/testargs.t | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/cpan/Test-Harness/t/testargs.t b/cpan/Test-Harness/t/testargs.t index cfbdd584c4..4fba59180a 100644 --- a/cpan/Test-Harness/t/testargs.t +++ b/cpan/Test-Harness/t/testargs.t @@ -59,7 +59,7 @@ sub make_shell_test { print $sh "#!$shell\n\n"; print $sh "$^X '$test' \$*\n"; } - chmod 0777, $script; + chmod 0775, $script; return unless -x $script; return [ shell => $script ]; } |