summaryrefslogtreecommitdiff
path: root/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Base.pm
diff options
context:
space:
mode:
authorN/K <snaury@gmail.com>2012-05-28 09:33:58 +0100
committerSteve Hay <steve.m.hay@googlemail.com>2012-05-28 09:43:01 +0100
commita970290aa9e323780a71583145a944c5b275701e (patch)
treeb4c570ce02b9c30597eeebf990b746ebeddbcfb8 /dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Base.pm
parentc2f56b9483cee11d5341b65afa8324d532b98b5e (diff)
downloadperl-a970290aa9e323780a71583145a944c5b275701e.tar.gz
[perl #111798] ExtUtils-CBuilder looks for the manifest file in the wrong place
Near the start of link(), $output gets set to a blib\arch\auto path. A little later that gets copied into $spec{output}, but $spec{manifest} is left unset so it gets set later to a $spec{builddir} path, which is not what $spec{output} was set to earlier. The manifest file is always created alongside the DLL, so the correct fix is simply to append '.manifest' to the DLL path to find the manifest. (EU-MM does that too.) Patch taken from [cpan #35943] which reported the same problem. The other concern raised there, about the VC version being checked to deduce the existence of the manifest file rather than testing that directly, has long since been incorporated already and also explains why this problem has not been seen recently: the faulty attempt to embed the manifest has not been attempted ever since the existence test was added because it was also failing and hence no 'mt' command was being run. [cpan #35943] is thus resolved by this change too. Bump $VERSION in all ExtUtils::CBuilder files (to 0.280208) to keep them all in sync as before.
Diffstat (limited to 'dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Base.pm')
-rw-r--r--dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Base.pm2
1 files changed, 1 insertions, 1 deletions
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Base.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Base.pm
index 0d8e1a115f..24f2165015 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Base.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Base.pm
@@ -12,7 +12,7 @@ use IPC::Cmd qw(can_run);
use File::Temp qw(tempfile);
use vars qw($VERSION);
-$VERSION = '0.280207';
+$VERSION = '0.280208';
# More details about C/C++ compilers:
# http://developers.sun.com/sunstudio/documentation/product/compiler.jsp