diff options
author | Tony Cook <tony@develop-help.com> | 2013-07-03 10:46:59 +1000 |
---|---|---|
committer | Tony Cook <tony@develop-help.com> | 2013-07-03 11:06:19 +1000 |
commit | da648063d21f624e2ae3c04a9b6d5b4c5b506e56 (patch) | |
tree | b557af42dcbcfcee95dd1917c574ab1e60731f20 /dist/base | |
parent | 0caa00cc099de25f4797fc2b0f467bb22e5ef11c (diff) | |
download | perl-da648063d21f624e2ae3c04a9b6d5b4c5b506e56.tar.gz |
[perl #118561] note that the check is fragile and refer to parent.pm
Diffstat (limited to 'dist/base')
-rw-r--r-- | dist/base/lib/base.pm | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/dist/base/lib/base.pm b/dist/base/lib/base.pm index 6b7d39ac8f..4c4b1d2c88 100644 --- a/dist/base/lib/base.pm +++ b/dist/base/lib/base.pm @@ -81,6 +81,12 @@ sub import { eval "require $base"; # Only ignore "Can't locate" errors from our eval require. # Other fatal errors (syntax etc) must be reported. + # + # changing the check here is fragile - if the check + # here isn't catching every error you want, you should + # probably be using parent.pm, which doesn't try to + # guess whether require is needed or failed, + # see [perl #118561] die if $@ && $@ !~ /^Can't locate .*? at \(eval /; unless (%{"$base\::"}) { require Carp; |