summaryrefslogtreecommitdiff
path: root/doio.c
diff options
context:
space:
mode:
authorTony Cook <tony@develop-help.com>2010-06-17 18:58:04 +1000
committerTony Cook <tony@develop-help.com>2010-06-25 21:48:38 +1000
commit8af710ebc7fee929ae47793d5a0cce5362af52db (patch)
tree38dcecb27b35c322bb9e0a57d36ac4858951719c /doio.c
parent133acf7b389614db651d1ed570d4a0ca0c747999 (diff)
downloadperl-8af710ebc7fee929ae47793d5a0cce5362af52db.tar.gz
RT #75812: apply get magic before checking flags, PVX
The code was checking flags with applying any get magic, so when a match was doing putting a numeric string into $1, none of the flags checked were set, so producing the "non-numeric process ID" error.
Diffstat (limited to 'doio.c')
-rw-r--r--doio.c9
1 files changed, 6 insertions, 3 deletions
diff --git a/doio.c b/doio.c
index 98861af131..06f2d3d4c3 100644
--- a/doio.c
+++ b/doio.c
@@ -1721,9 +1721,10 @@ nothing in the core.
while (++mark <= sp) {
I32 proc;
register unsigned long int __vmssts;
+ SvGETMAGIC(*mark);
if (!(SvIOK(*mark) || SvNOK(*mark) || looks_like_number(*mark)))
Perl_croak(aTHX_ "Can't kill a non-numeric process ID");
- proc = SvIV(*mark);
+ proc = SvIV_nomg(*mark);
APPLY_TAINT_PROPER();
if (!((__vmssts = sys$delprc(&proc,0)) & 1)) {
tot--;
@@ -1748,9 +1749,10 @@ nothing in the core.
val = -val;
while (++mark <= sp) {
I32 proc;
+ SvGETMAGIC(*mark);
if (!(SvIOK(*mark) || SvNOK(*mark) || looks_like_number(*mark)))
Perl_croak(aTHX_ "Can't kill a non-numeric process ID");
- proc = SvIV(*mark);
+ proc = SvIV_nomg(*mark);
APPLY_TAINT_PROPER();
#ifdef HAS_KILLPG
if (PerlProc_killpg(proc,val)) /* BSD */
@@ -1763,9 +1765,10 @@ nothing in the core.
else {
while (++mark <= sp) {
I32 proc;
+ SvGETMAGIC(*mark);
if (!(SvIOK(*mark) || SvNOK(*mark) || looks_like_number(*mark)))
Perl_croak(aTHX_ "Can't kill a non-numeric process ID");
- proc = SvIV(*mark);
+ proc = SvIV_nomg(*mark);
APPLY_TAINT_PROPER();
if (PerlProc_kill(proc, val))
tot--;