-l followed by bareword should leave the stack alone

$ ln -s /usr/bin/perl bar
$ perl -le' print "bar", -l foo'
1

The -l ate my bar.

It’s this naughty piece of code in doio.c:Perl_my_lstat_flags that is
the culprit:

 	if (ckWARN(WARN_IO)) {
 	    Perl_warner(aTHX_ packWARN(WARN_IO), "Use of -l on filehandle %s",
 		    GvENAME(cGVOP_gv));
 	    return (PL_laststatval = -1);
 	}

When -l is followed by a bareward, it has no argument on the stack,
but the filetest op itself is a gvop.  That snippet is from the bare-
word-handling code.

So, if warnings are off, it falls through to the argument-on-the-stack
code and pops off something does not belong to it (that belong to the
print, in the example above).

1 files changed, 1 insertions, 1 deletions

diff --git a/doio.c b/doio.c
index 4626da1627..1ce6acc4ae 100644
--- a/doio.c
+++ b/doio.c
@@ -1344,8 +1344,8 @@ Perl_my_lstat_flags(pTHX_ const U32 flags)
 	if (ckWARN(WARN_IO)) {
 	    Perl_warner(aTHX_ packWARN(WARN_IO), "Use of -l on filehandle %s",
 		    GvENAME(cGVOP_gv));
-	    return (PL_laststatval = -1);
 	}
+	return (PL_laststatval = -1);
     }
     else if (PL_laststype != OP_LSTAT
 	    && (PL_op->op_private & OPpFT_STACKED) && ckWARN(WARN_IO))