Add memCHRs() macro and use it

This replaces strchr("list", c) calls throughout the core.  They don't
work properly when 'c' is a NUL, returning the position of the
terminating NUL in "list" instead of failure.  This could lead to
segfaults or even security issues.

1 files changed, 1 insertions, 1 deletions

diff --git a/doio.c b/doio.c
index 424e0e3205..c57750e942 100644
--- a/doio.c
+++ b/doio.c
@@ -2419,7 +2419,7 @@ Perl_do_exec3(pTHX_ const char *incmd, int fd, int do_report)
 
     for (s = cmd; *s; s++) {
 	if (*s != ' ' && !isALPHA(*s) &&
-	    strchr("$&*(){}[]'\";\\|?<>~`\n",*s)) {
+	    memCHRs("$&*(){}[]'\";\\|?<>~`\n",*s)) {
 	    if (*s == '\n' && !s[1]) {
 		*s = '\0';
 		break;