diff options
| author | Nicholas Clark <nick@ccl4.org> | 2010-10-20 21:28:30 +0200 |
|---|---|---|
| committer | Nicholas Clark <nick@ccl4.org> | 2010-10-21 11:34:59 +0200 |
| commit | f4603e303c60a90bd9050fdc96683a33e69bb849 (patch) | |
| tree | fb36ec864349ee7a3f0e618fdd8c4c1a1920fbc4 /ext/SDBM_File | |
| parent | a5c6857cbad41a80aba26d560558a58cbba0505f (diff) | |
| download | perl-f4603e303c60a90bd9050fdc96683a33e69bb849.tar.gz | |
In SDBM_File.xs, store the 4 filter functions as 1 array in the struct.
Previously they were 1 distinct members. Using an array allows the use of a loop
in sdbm_DESTROY, and merging of the 4 XS functions
filter_{fetch,store}_{key,value} into 1 body with ALIASes.
Diffstat (limited to 'ext/SDBM_File')
| -rw-r--r-- | ext/SDBM_File/SDBM_File.xs | 55 | ||||
| -rw-r--r-- | ext/SDBM_File/typemap | 8 |
2 files changed, 21 insertions, 42 deletions
diff --git a/ext/SDBM_File/SDBM_File.xs b/ext/SDBM_File/SDBM_File.xs index ac16062800..23d86b5717 100644 --- a/ext/SDBM_File/SDBM_File.xs +++ b/ext/SDBM_File/SDBM_File.xs @@ -4,12 +4,14 @@ #include "XSUB.h" #include "sdbm/sdbm.h" +#define fetch_key 0 +#define store_key 1 +#define fetch_value 2 +#define store_value 3 + typedef struct { DBM * dbp ; - SV * filter_fetch_key ; - SV * filter_store_key ; - SV * filter_fetch_value ; - SV * filter_store_value ; + SV * filter[4]; int filtering ; } SDBM_File_type; @@ -53,15 +55,12 @@ sdbm_DESTROY(db) SDBM_File db CODE: if (db) { + int i = store_value; sdbm_close(db->dbp); - if (db->filter_fetch_key) - SvREFCNT_dec(db->filter_fetch_key) ; - if (db->filter_store_key) - SvREFCNT_dec(db->filter_store_key) ; - if (db->filter_fetch_value) - SvREFCNT_dec(db->filter_fetch_value) ; - if (db->filter_store_value) - SvREFCNT_dec(db->filter_store_value) ; + do { + if (db->filter[i]) + SvREFCNT_dec(db->filter[i]); + } while (i-- > 0); safefree(db) ; } @@ -126,30 +125,10 @@ filter_fetch_key(db, code) SDBM_File db SV * code SV * RETVAL = &PL_sv_undef ; + ALIAS: + SDBM_File::filter_fetch_key = fetch_key + SDBM_File::filter_store_key = store_key + SDBM_File::filter_fetch_value = fetch_value + SDBM_File::filter_store_value = store_value CODE: - DBM_setFilter(db->filter_fetch_key, code) ; - -SV * -filter_store_key(db, code) - SDBM_File db - SV * code - SV * RETVAL = &PL_sv_undef ; - CODE: - DBM_setFilter(db->filter_store_key, code) ; - -SV * -filter_fetch_value(db, code) - SDBM_File db - SV * code - SV * RETVAL = &PL_sv_undef ; - CODE: - DBM_setFilter(db->filter_fetch_value, code) ; - -SV * -filter_store_value(db, code) - SDBM_File db - SV * code - SV * RETVAL = &PL_sv_undef ; - CODE: - DBM_setFilter(db->filter_store_value, code) ; - + DBM_setFilter(db->filter[ix], code); diff --git a/ext/SDBM_File/typemap b/ext/SDBM_File/typemap index a06ce81aad..d1fc497f45 100644 --- a/ext/SDBM_File/typemap +++ b/ext/SDBM_File/typemap @@ -17,12 +17,12 @@ INPUT T_DATUM_K { STRLEN len; - DBM_ckFilter($arg, filter_store_key, \"filter_store_key\"); + DBM_ckFilter($arg, filter[store_key], \"filter_store_key\"); $var.dptr = SvPVbyte($arg, len); $var.dsize = (int)len; } T_DATUM_V - DBM_ckFilter($arg, filter_store_value, \"filter_store_value\"); + DBM_ckFilter($arg, filter[store_value], \"filter_store_value\"); if (SvOK($arg)) { STRLEN len; $var.dptr = SvPVbyte($arg, len); @@ -37,10 +37,10 @@ T_GDATUM OUTPUT T_DATUM_K sv_setpvn($arg, $var.dptr, $var.dsize); - DBM_ckFilter($arg, filter_fetch_key,\"filter_fetch_key\"); + DBM_ckFilter($arg, filter[fetch_key],\"filter_fetch_key\"); T_DATUM_V sv_setpvn($arg, $var.dptr, $var.dsize); - DBM_ckFilter($arg, filter_fetch_value,\"filter_fetch_value\"); + DBM_ckFilter($arg, filter[fetch_value],\"filter_fetch_value\"); T_GDATUM sv_usepvn($arg, $var.dptr, $var.dsize); T_PTROBJ |