diff options
| author | Nicholas Clark <nick@ccl4.org> | 2004-03-18 16:58:06 +0000 |
|---|---|---|
| committer | Nicholas Clark <nick@ccl4.org> | 2004-03-18 16:58:06 +0000 |
| commit | 17625bd2bf8805259796589d280425017e98f645 (patch) | |
| tree | 47d33f7893db045edb90c0f10527ca7a169748bc /ext/Storable | |
| parent | 0fa75b596fec0b917a3b53aa7158ea091521d82f (diff) | |
| download | perl-17625bd2bf8805259796589d280425017e98f645.tar.gz | |
Corrections and explanations in comments
p4raw-id: //depot/perl@22528
Diffstat (limited to 'ext/Storable')
| -rw-r--r-- | ext/Storable/Storable.xs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/ext/Storable/Storable.xs b/ext/Storable/Storable.xs index 2d4409777c..7f47983661 100644 --- a/ext/Storable/Storable.xs +++ b/ext/Storable/Storable.xs @@ -2455,7 +2455,7 @@ static int store_code(stcxt_t *cxt, CV *cv) * Require B::Deparse. At least B::Deparse 0.61 is needed for * blessed code references. */ - /* XXX sv_2mortal seems to be evil here. why? */ + /* Ownership of both SVs is passed to load_module, which frees them. */ load_module(PERL_LOADMOD_NOIMPORT, newSVpvn("B::Deparse",10), newSVnv(0.61)); ENTER; @@ -3315,7 +3315,7 @@ static int store(stcxt_t *cxt, SV *sv) */ /* Need to jump past the next hv_store, because on the second store of undef the old hash value will be - SV_REFCNT_DEC()ed, and as Storable cheats horribly + SvREFCNT_dec()ed, and as Storable cheats horribly by storing non-SVs in the hash a SEGV will ensure. Need to increase the tag number so that the receiver has no idea what games we're up to. This |