Change white space to avoid C++ deprecation warning

C++11 requires space between the end of a string literal and a macro, so
that a feature can unambiguously be added to the language.  Starting in
g++ 6.2, the compiler emits a warning when there isn't a space
(presumably so that future versions can support C++11).  Unfortunately
there are many such instances in the perl core.  This commit fixes
those, including those in ext/, but individual commits will be used for
the other modules, those in dist/ and cpan/.

This commit also inserts space at the end of a macro before a string
literal, even though that is not deprecated, and removes useless ""
literals following a macro (instead of inserting a blank).  The result
is easier to read, making the macro stand out, and be clearer as to the
intention.

Code and modules included with the Perl core need to be compilable using
C++.  This is so that perl can be embedded in C++ programs. (Actually,
only the hdr files need to be so compilable, but it would be hard to
test that just the hdrs are compilable.)  So we need to accommodate
changes to the C++ language.

1 files changed, 9 insertions, 8 deletions

diff --git a/ext/XS-APItest/APItest.xs b/ext/XS-APItest/APItest.xs
index bb22e6ca65..c58e248c89 100644
--- a/ext/XS-APItest/APItest.xs
+++ b/ext/XS-APItest/APItest.xs
@@ -1258,8 +1258,8 @@ static void
 peep_xop(pTHX_ OP *o, OP *oldop)
 {
     dMY_CXT;
-    av_push(MY_CXT.xop_record, newSVpvf("peep:%"UVxf, PTR2UV(o)));
-    av_push(MY_CXT.xop_record, newSVpvf("oldop:%"UVxf, PTR2UV(oldop)));
+    av_push(MY_CXT.xop_record, newSVpvf("peep:%" UVxf, PTR2UV(o)));
+    av_push(MY_CXT.xop_record, newSVpvf("oldop:%" UVxf, PTR2UV(oldop)));
 }
 
 static I32
@@ -1849,7 +1849,7 @@ refcounted_he_exists(key, level=0)
 	IV level
 	CODE:
 	if (level) {
-	    croak("level must be zero, not %"IVdf, level);
+	    croak("level must be zero, not %" IVdf, level);
 	}
 	RETVAL = (cop_hints_fetch_sv(PL_curcop, key, 0, 0) != &PL_sv_placeholder);
 	OUTPUT:
@@ -1861,7 +1861,7 @@ refcounted_he_fetch(key, level=0)
 	IV level
 	CODE:
 	if (level) {
-	    croak("level must be zero, not %"IVdf, level);
+	    croak("level must be zero, not %" IVdf, level);
 	}
 	RETVAL = cop_hints_fetch_sv(PL_curcop, key, 0, 0);
 	SvREFCNT_inc(RETVAL);
@@ -2069,8 +2069,8 @@ xop_build_optree ()
         unop->op_next       = NULL;
         kid->op_next        = (OP*)unop;
 
-        av_push(MY_CXT.xop_record, newSVpvf("unop:%"UVxf, PTR2UV(unop)));
-        av_push(MY_CXT.xop_record, newSVpvf("kid:%"UVxf, PTR2UV(kid)));
+        av_push(MY_CXT.xop_record, newSVpvf("unop:%" UVxf, PTR2UV(unop)));
+        av_push(MY_CXT.xop_record, newSVpvf("kid:%" UVxf, PTR2UV(kid)));
 
         av_push(MY_CXT.xop_record, newSVpvf("NAME:%s", OP_NAME((OP*)unop)));
         av_push(MY_CXT.xop_record, newSVpvf("DESC:%s", OP_DESC((OP*)unop)));
@@ -4128,7 +4128,7 @@ lexical_import(SV *name, CV *cv)
 	SAVESPTR(PL_comppad_name); PL_comppad_name = PadlistNAMES(pl);
 	SAVESPTR(PL_comppad);	   PL_comppad	   = PadlistARRAY(pl)[1];
 	SAVESPTR(PL_curpad);	   PL_curpad	   = PadARRAY(PL_comppad);
-	off = pad_add_name_sv(sv_2mortal(newSVpvf("&%"SVf,name)),
+	off = pad_add_name_sv(sv_2mortal(newSVpvf("&%" SVf,name)),
 			      padadd_STATE, 0, 0);
 	SvREFCNT_dec(PL_curpad[off]);
 	PL_curpad[off] = SvREFCNT_inc(cv);
@@ -4235,7 +4235,8 @@ CODE:
     } else if (items == 3) {
 	Perl_load_module(aTHX_ flags, SvREFCNT_inc(name), SvREFCNT_inc(ST(2)));
     } else
-        Perl_croak(aTHX_ "load_module can't yet support %"IVdf" items", (IV)items);
+        Perl_croak(aTHX_ "load_module can't yet support %" IVdf " items",
+                          (IV)items);
 
 SV *
 string_without_null(SV *sv)