diff options
| author | Ævar Arnfjörð Bjarmason <avar@cpan.org> | 2014-06-21 17:44:20 +0000 |
|---|---|---|
| committer | Ævar Arnfjörð Bjarmason <avar@cpan.org> | 2014-06-21 17:58:43 +0000 |
| commit | aaa63daea7f8ece57d84d8329754f95ea107301e (patch) | |
| tree | 2723b291b86bd26f2190f99be6858157f2e08af1 /ext/XS-APItest/t | |
| parent | 43d7f0da895d00d0f557ad72549ddb3194763b55 (diff) | |
| download | perl-aaa63daea7f8ece57d84d8329754f95ea107301e.tar.gz | |
Make like() and unlike() in t/test.pl refuse non-qr// arguments
As I noted in v5.21.1-12-g826af13 we have subtle bugs in the test suite
because you can do e.g. like($@, '') now which'll be a passing test even
when we have an error, because $@ =~ // will be true.
I'm just changing t/test.pl to not accept non-Regexp arguments, and
fixing up a bunch of test failures that resulted from that. There might
still be more of these in tests that I'm just not running, I've also
changed some of these from $str =~ /foo/ to $str eq 'foo'
(i.e. s/like/is/) in cases where that appeared to work, but it might
break some systems.
Let's just find that out via the smokers.
Diffstat (limited to 'ext/XS-APItest/t')
| -rw-r--r-- | ext/XS-APItest/t/call.t | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ext/XS-APItest/t/call.t b/ext/XS-APItest/t/call.t index 54f45ec489..9ab633d77e 100644 --- a/ext/XS-APItest/t/call.t +++ b/ext/XS-APItest/t/call.t @@ -279,7 +279,7 @@ for my $fn_type (0..2) { # 0:eval_pv 1:eval_sv 2:call_sv } else { is($warn_msg, undef, "$desc - __WARN__ not called"); - unlike($@, 'pre-err', "$desc - \$@ modified"); + unlike($@, qr/pre-err/, "$desc - \$@ modified"); } like($@, ( |