diff options
| author | David Mitchell <davem@iabyn.com> | 2010-03-30 15:03:50 +0100 |
|---|---|---|
| committer | David Mitchell <davem@iabyn.com> | 2010-03-30 15:03:50 +0100 |
| commit | 099be4f1d597471eb719c9a344b7c1b55e11ba24 (patch) | |
| tree | 46ddeb749d35c52c3df9d34f54e7200aef8ddbcf /gv.c | |
| parent | 447ee1343739cf8e34c4ff1ba9b30eae75c3f1ab (diff) | |
| download | perl-099be4f1d597471eb719c9a344b7c1b55e11ba24.tar.gz | |
PL_defoutgv isn't always a GV.
Nasty code like the following results in PL_defoutgv not pointing
to a valid GV:
my $x = *STDERR; select($x); $x = 1;
This causes all sorts of SEGVs when PL_defoutgv is subsequently accessed,
because most code assumes that it has a valid gv_gp pointer. It also
turns out that PL_defoutgv is under-tested; for example, temporarily
hacking pp_close to make an arg-less close() croak didn't cause any
minitest failures.
Add a new test file that does some basic testing of a bad PL_defoutgv,
and fix all the obvious badness in accessing it.
This also fixes #20727, which although ostensibly a tie bug, was due to
PL_defoutgv pointing to a tiedelem scalar, and fun like that described
above happening.
Diffstat (limited to 'gv.c')
| -rw-r--r-- | gv.c | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -1468,7 +1468,7 @@ Perl_gv_fullname4(pTHX_ SV *sv, const GV *gv, const char *prefix, bool keepmain) void Perl_gv_efullname4(pTHX_ SV *sv, const GV *gv, const char *prefix, bool keepmain) { - const GV * const egv = GvEGV(gv); + const GV * const egv = GvEGVx(gv); PERL_ARGS_ASSERT_GV_EFULLNAME4; @@ -2394,7 +2394,7 @@ Perl_gv_try_downgrade(pTHX_ GV *gv) isGV_with_GP(gv) && GvGP(gv) && !GvINTRO(gv) && GvREFCNT(gv) == 1 && !GvSV(gv) && !GvAV(gv) && !GvHV(gv) && !GvIOp(gv) && !GvFORM(gv) && - GvEGV(gv) == gv && (stash = GvSTASH(gv)))) + GvEGVx(gv) == gv && (stash = GvSTASH(gv)))) return; cv = GvCV(gv); if (!cv) { |