[inseparable changes from patch from perl5.003_13 to perl5.003_14]

 CORE LANGUAGE CHANGES

Subject: Eliminate support for {if,unless,while,until} BLOCK BLOCK
From: Chip Salzenberg <chip@atlantic.net>
Files: perly.c perly.c.diff perly.y toke.c

Subject: Taint $x after $x =~ s/pat/xyz/ if pat or xyz is tainted by locale
From: Chip Salzenberg <chip@atlantic.net>
Files: cop.h mg.c pp_ctl.c pp_hot.c

Subject: Complete support for modifying undefined array members in foreach
From: Chip Salzenberg <chip@atlantic.net>
Files: global.sym mg.c perl.h pp.c pp_hot.c proto.h sv.c

 DOCUMENTATION

Subject: Update pod/Makefile; s/perli18n/perllocale/
From: Chip Salzenberg <chip@atlantic.net>
Files: ext/POSIX/POSIX.pod lib/I18N/Collate.pm pod/Makefile pod/perl.pod pod/perlmod.pod pod/perlnews.pod pod/roffitall

 OTHER CORE CHANGES

Subject: Bug in debugger with import manipulations
Date: Mon, 23 Dec 1996 05:37:48 -0500 (EST)
From: Ilya Zakharevich <ilya@math.ohio-state.edu>
Files: pp_hot.c

    Finally I traced why MakeMaker runs wrongly under debugger: debugger
    function calling sequence was assuming that
    	GvCV(CvGV(cv)) == cv
    for non-anonymous subs (ne END). MakeMaker managed to break it by
    	*A::B = \&C::D;
    	eval 'sub C::D {new one}';
    
    After this CvGV(\&A::B) is *C::D, but &{*C::D} is the "new one".
    
    Patch follows (note that in this case we do not sacrifice having a
    subroutine name in debugger output ;-).
    
    Enjoy,
    
    p5p-msgid: <199612231037.FAA08617@monk.mps.ohio-state.edu>

Subject: Import and dynamic methods
Date: Mon, 23 Dec 1996 01:45:37 -0500 (EST)
From: Ilya Zakharevich <ilya@math.ohio-state.edu>
Files: gv.c hv.c sv.c

    Here is the patch which corrects bad things which happens when you
    import subroutines and otherwise manipulate the symbol tree.
    
    I put forward the only chunk which may be controversal, since it may
    have a minor performance penalty. It is independent of the others, so
    it can be freely deleted.
    
    The manipulations which correctly propagate to method calls:
    	a) Pruning globs:		delete $B::{method}
    	b) Undefing subroutines:	undef &B::method;
    	c) Importing:			*B::method = \&mymethod;
    
    Enjoy,
    
    p5p-msgid: <199612230645.BAA08378@monk.mps.ohio-state.edu>

Subject: sv_gets patch
Date: Sun, 22 Dec 1996 03:24:04 -0500 (EST)
From: Ilya Zakharevich <ilya@math.ohio-state.edu>
Files: pp_hot.c

    I sent this patch before as a part of 
    	pos $str =
    	$str = /failing/g
    patch. Now I separate it in the case it was tainted by environment:
    
    Synopsis:
    	$a = <FH>;
    does not work as expected if $a is magic (say, tied).
    
    Enjoy,
    
    p5p-msgid: <199612220824.DAA07235@monk.mps.ohio-state.edu>

Subject: pos $str patch
Date: Sun, 22 Dec 1996 03:31:21 -0500 (EST)
From: Ilya Zakharevich <ilya@math.ohio-state.edu>
Files: mg.c pp_hot.c t/op/pat.t

    This patch was (mostly) posted already.
    
    It fixes the bug:
    	pos $str 
    is reset to undef if
    	$str =~ /failing/g
    fails.
    
    Additionally, if fixes the hidded bit (=MGf_MINMATCH) surviving
    setting 
    	pos $str = ...
    
    Enjoy,
    
    p5p-msgid: <199612220831.DAA07247@monk.mps.ohio-state.edu>

 PORTABILITY

Subject: Fix bugs in bincompat3 usage
From: Chip Salzenberg <chip@atlantic.net>
Files: perl.h perl_exp.SH

Subject: VMS patches to 5.003_13
Date: Mon, 23 Dec 1996 01:26:47 -0500 (EST)
From: Charles Bailey <bailey@HMIVAX.HUMGEN.UPENN.EDU>
Files: deb.c ext/POSIX/POSIX.xs gv.c lib/File/Copy.pm mg.c perl.c perl.h proto.h sv.c t/lib/filecopy.t taint.c toke.c util.c vms/Makefile vms/config.vms vms/descrip.mms vms/gen_shrfls.pl vms/genconfig.pl vms/genopt.com vms/perly_c.vms vms/perly_h.vms vms/test.com vms/vms.c vms/vms_yfix.pl

    private-msgid: <01IDBYYFYPIS002ASE@hmivax.humgen.upenn.edu>

 UTILITIES, LIBRARY, AND EXTENSIONS

Subject: Remove libnet
From: Chip Salzenberg <chip@atlantic.net>
Files: MANIFEST pod/perlmod.pod

Subject: Update IO->VERSION() to 1.1201 for CPAN's sake
From: Chip Salzenberg <chip@atlantic.net>
Files: ext/IO/lib/IO/Handle.pm lib/IO/Handle.pm

Subject: Remodel File::Copy.
From: Chip Salzenberg <chip@atlantic.net>
Files: lib/File/Copy.pm

1 files changed, 13 insertions, 22 deletions

diff --git a/gv.c b/gv.c
index 95efca8468..8db44b42f0 100644
--- a/gv.c
+++ b/gv.c
@@ -19,7 +19,7 @@
 #include "EXTERN.h"
 #include "perl.h"
 
-extern char rcsid[];
+EXT char rcsid[];
 
 GV *
 gv_AVadd(gv)
@@ -143,19 +143,18 @@ I32 level;
     if (SvTYPE(topgv) != SVt_PVGV)
 	gv_init(topgv, stash, name, len, TRUE);
 
-    if (cv=GvCV(topgv)) {
-	if (GvCVGEN(topgv) >= sub_generation)
-	    return topgv;	/* valid cached inheritance */
-	if (!GvCVGEN(topgv)) {	/* not an inheritance cache */
-	    return topgv;
-	}
-	else {
-	    /* stale cached entry, just junk it */
-	    GvCV(topgv) = cv = 0;
-	    GvCVGEN(topgv) = 0;
+    if (cv = GvCV(topgv)) {
+	if (CvXSUB(cv) || CvROOT(cv)) { /* Not undefed. */
+	    if (!GvCVGEN(topgv) ||	/* not an inheritance cache */
+		GvCVGEN(topgv) >= sub_generation) /* valid inh. cache */
+		return topgv;
 	}
+	/* stale cached entry, just junk it */
+	SvREFCNT_dec(cv);
+	GvCV(topgv) = cv = 0;
+	GvCVGEN(topgv) = 0;
     }
-    /* if cv is still set, we have to free it if we find something to cache */
+    /* Now cv = 0, and there is no cv in topgv. */
 
     gvp = (GV**)hv_fetch(stash,"ISA",3,FALSE);
     if (gvp && (gv = *gvp) != (GV*)&sv_undef && (av = GvAV(gv))) {
@@ -172,13 +171,9 @@ I32 level;
 	    }
 	    gv = gv_fetchmeth(basestash, name, len, level + 1);
 	    if (gv) {
-		if (cv) {				/* junk old undef */
-		    assert(SvREFCNT(topgv) > 1);
-		    SvREFCNT_dec(topgv);
-		    SvREFCNT_dec(cv);
-		}
 		GvCV(topgv) = GvCV(gv);			/* cache the CV */
 		GvCVGEN(topgv) = sub_generation;	/* valid for now */
+		SvREFCNT_inc(GvCV(gv));
 		return gv;
 	    }
 	}
@@ -187,13 +182,9 @@ I32 level;
     if (!level) {
 	if (lastchance = gv_stashpvn("UNIVERSAL", 9, FALSE)) {
 	    if (gv = gv_fetchmeth(lastchance, name, len, level + 1)) {
-		if (cv) {				/* junk old undef */
-		    assert(SvREFCNT(topgv) > 1);
-		    SvREFCNT_dec(topgv);
-		    SvREFCNT_dec(cv);
-		}
 		GvCV(topgv) = GvCV(gv);			/* cache the CV */
 		GvCVGEN(topgv) = sub_generation;	/* valid for now */
+		SvREFCNT_inc(GvCV(gv));
 		return gv;
 	    }
 	}