diff options
| author | Father Chrysostomos <sprout@cpan.org> | 2012-07-10 00:26:12 -0700 |
|---|---|---|
| committer | Father Chrysostomos <sprout@cpan.org> | 2012-07-12 13:20:10 -0700 |
| commit | 3107b51fb9c191a2ee82450f00c4568640538e12 (patch) | |
| tree | 8dd54b1256f71ecfd6cd46f74ba82085dc6cc988 /intrpvar.h | |
| parent | 8f55039992b2378df3dcb99bb2ec67d80b7c8854 (diff) | |
| download | perl-3107b51fb9c191a2ee82450f00c4568640538e12.tar.gz | |
PERL_DEBUG_READONLY_OPS with the new allocator
I want to eliminate the old slab allocator (PL_OP_SLAB_ALLOC),
but this useful debugging tool needs to be rewritten for the new
one first.
This is slightly better than under PL_OP_SLAB_ALLOC, in that CVs cre-
ated after the main CV starts running will get read-only ops, too. It
is when a CV finishes compiling and relinquishes ownership of the slab
that the slab is made read-only, because at that point it should not
be used again for allocation.
BEGIN blocks are exempt, as they are processed before the Slab_to_ro
call in newATTRSUB. The Slab_to_ro call must come at the very end,
after LEAVE_SCOPE, because otherwise the ops freed via the stack (the
SAVEFREEOP calls near the top of newATTRSUB) will make the slab writa-
ble again. At that point, the BEGIN block has already been run and
its slab freed. Maybe slabs belonging to BEGIN blocks can be made
read-only later.
Under PERL_DEBUG_READONLY_OPS, op slabs have two extra fields to
record the size and readonliness of each slab. (Only the first slab
in a CV’s slab chain uses the readonly flag, since it is conceptually
simpler to treat them all as one unit.) Without recording this infor-
mation manually, things become unbearably slow, the tests taking hours
and hours instead of minutes.
Diffstat (limited to 'intrpvar.h')
| -rw-r--r-- | intrpvar.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/intrpvar.h b/intrpvar.h index 3e9600f2d4..330551bcbd 100644 --- a/intrpvar.h +++ b/intrpvar.h @@ -812,11 +812,11 @@ PERLVARI(I, xmlfp, PerlIO *, NULL) PERLVAR(I, OpPtr, I32 **) PERLVARI(I, OpSpace, I32, 0) PERLVAR(I, OpSlab, I32 *) -#endif -#ifdef PERL_DEBUG_READONLY_OPS +# ifdef PERL_DEBUG_READONLY_OPS PERLVARI(I, slabs, I32**, NULL) /* Array of slabs that have been allocated */ PERLVARI(I, slab_count, U32, 0) /* Size of the array */ +# endif #endif #ifdef DEBUG_LEAKING_SCALARS |