diff options
| author | Nicholas Clark <nick@ccl4.org> | 2010-09-08 10:24:04 +0100 |
|---|---|---|
| committer | Nicholas Clark <nick@ccl4.org> | 2010-09-08 10:24:04 +0100 |
| commit | 9a87bd09eea1d037e82e99f6ece528e39e7fe0e6 (patch) | |
| tree | 687527f4f2be761e544a22f09e7bbd4ee0a51141 /intrpvar.h | |
| parent | ea25a9b2cf73948b1e8c5675de027e0ad13277bd (diff) | |
| download | perl-9a87bd09eea1d037e82e99f6ece528e39e7fe0e6.tar.gz | |
Remove offer_nice_chunk(), PL_nice_chunk and PL_nice_chunk_size.
These provided a non-public API for the hash and array code to donate free
memory direct to the SV head allocation routines, instead of returning it
to the malloc system with free().
I assume that on some older mallocs this could offer significant benefits.
However, my benchmarking on a modern malloc couldn't detect any significant
effect (positive or negative) on removing the code. Its (continued) presence,
however, has downsides
a: slightly more code complexity
b: slightly larger interpreter structure
c: in the steady state, if net creation of SVs is zero, 1 chunk of allocated
but unused memory will exist (per thread)
So I think it best to remove it.
Diffstat (limited to 'intrpvar.h')
| -rw-r--r-- | intrpvar.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/intrpvar.h b/intrpvar.h index 503d9d666f..749be42395 100644 --- a/intrpvar.h +++ b/intrpvar.h @@ -445,8 +445,7 @@ PERLVAR(Isighandlerp, Sighandler_t) PERLVARA(Ibody_roots, PERL_ARENA_ROOTS_SIZE, void*) /* array of body roots */ -PERLVAR(Inice_chunk, char *) /* a nice chunk of memory to reuse */ -PERLVAR(Inice_chunk_size, U32) /* how nice the chunk of memory is */ +/* Space for an int */ PERLVARI(Imaxo, int, MAXO) /* maximum number of ops */ |