diff options
| author | Brian Fraser <fraserbn@gmail.com> | 2013-05-23 00:44:15 -0300 |
|---|---|---|
| committer | Tony Cook <tony@develop-help.com> | 2013-06-04 18:45:38 +1000 |
| commit | dfff4baff950c3688d6f16335fa1e1037bb84bd0 (patch) | |
| tree | 93d04ea7777f2ff99152da88b12a87004fdb8671 /iperlsys.h | |
| parent | bcbe2b27bd9868685fb7b4a6158b08674d0387cd (diff) | |
| download | perl-dfff4baff950c3688d6f16335fa1e1037bb84bd0.tar.gz | |
Stop making assumptions about uids and gids.
The code dealt rather inconsistently with uids and gids. Some
places assumed that they could be safely stored in UVs, others
in IVs, others in ints; All of them should've been using the
macros from config.h instead. Similarly, code that created
SVs or pushed values into the stack was also making incorrect
assumptions -- As a point of reference, only pp_stat did the
right thing:
#if Uid_t_size > IVSIZE
mPUSHn(PL_statcache.st_uid);
#else
# if Uid_t_sign <= 0
mPUSHi(PL_statcache.st_uid);
# else
mPUSHu(PL_statcache.st_uid);
# endif
#endif
The other places were potential bugs, and some were even causing
warnings in some unusual OSs, like haiku or qnx.
This commit ammends the situation by introducing four new macros,
SvUID(), sv_setuid(), SvGID(), and sv_setgid(), and using them
where needed.
Diffstat (limited to 'iperlsys.h')
| -rw-r--r-- | iperlsys.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/iperlsys.h b/iperlsys.h index b23f4d3eb2..003405f690 100644 --- a/iperlsys.h +++ b/iperlsys.h @@ -933,10 +933,10 @@ typedef int (*LPProcExecv)(struct IPerlProc*, const char*, const char*const*); typedef int (*LPProcExecvp)(struct IPerlProc*, const char*, const char*const*); -typedef uid_t (*LPProcGetuid)(struct IPerlProc*); -typedef uid_t (*LPProcGeteuid)(struct IPerlProc*); -typedef gid_t (*LPProcGetgid)(struct IPerlProc*); -typedef gid_t (*LPProcGetegid)(struct IPerlProc*); +typedef Uid_t (*LPProcGetuid)(struct IPerlProc*); +typedef Uid_t (*LPProcGeteuid)(struct IPerlProc*); +typedef Gid_t (*LPProcGetgid)(struct IPerlProc*); +typedef Gid_t (*LPProcGetegid)(struct IPerlProc*); typedef char* (*LPProcGetlogin)(struct IPerlProc*); typedef int (*LPProcKill)(struct IPerlProc*, int, int); typedef int (*LPProcKillpg)(struct IPerlProc*, int, int); |