summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorKarl Williamson <public@khwilliamson.com>2010-10-10 08:57:56 -0600
committerFather Chrysostomos <sprout@cpan.org>2010-10-12 13:50:41 -0700
commitd1d1cd7a762a87ab5e8d99734e7e804b84a88739 (patch)
tree4a453a862ee02824ad4570e5e959db7252e4d101 /lib
parent0a9dbafce21ad4191e66a5fde3186bb2e61ca726 (diff)
downloadperl-d1d1cd7a762a87ab5e8d99734e7e804b84a88739.tar.gz
mktables: complement variable name for rebuilding
This is an intermediate patch that changes the variable name as to whether the files need rebuilding or not to something I understand better. This has long been confusing, as up until a year ago, there had been a long-standing bug in the program that didn't get it right.
Diffstat (limited to 'lib')
-rw-r--r--lib/unicore/mktables12
1 files changed, 6 insertions, 6 deletions
diff --git a/lib/unicore/mktables b/lib/unicore/mktables
index b03c9358e6..41c96c556c 100644
--- a/lib/unicore/mktables
+++ b/lib/unicore/mktables
@@ -13978,16 +13978,16 @@ foreach my $in (@input_files) {
}
}
-my $ok = ! $write_unchanged_files
- && scalar @mktables_list_output_files; # If none known, rebuild
+my $rebuild = ! (! $write_unchanged_files
+ && scalar @mktables_list_output_files); # If none known, rebuild
# Now we check to see if any output files are older than youngest, if
# they are, we need to continue on, otherwise we can presumably bail.
-if ($ok) {
+if (! $rebuild) {
foreach my $out (@mktables_list_output_files) {
if ( ! file_exists($out)) {
print "'$out' is missing.\n" if $verbosity >= $VERBOSE;
- $ok = 0;
+ $rebuild = 1;
last;
}
#local $to_trace = 1 if main::DEBUG;
@@ -13995,12 +13995,12 @@ if ($ok) {
if ( -M $out > $youngest ) {
#trace "$out: age: ", -M $out, ", youngest: $youngest\n" if main::DEBUG && $to_trace;
print "'$out' is too old.\n" if $verbosity >= $VERBOSE;
- $ok = 0;
+ $rebuild = 1;
last;
}
}
}
-if ($ok) {
+if (! $rebuild) {
print "Files seem to be ok, not bothering to rebuild. Add '-w' option to force build\n";
exit(0);
}