Simplify lib/File/stat.t by using a tempfile as the test victim.

The previous code had got very gnarly trying to use a file from the
distribution for the test file, attempting to cope with
1) Other programs reading the file and hence the atime updating
2) The perl interpreter reading the file and hence the atime updating :-)
3) Building with -Dmksymlinks meaning that the file is a symlink

All these problems and work arounds simply *vanish* if we use a tempfile.
This will also enable us to change its mode in the future for better testing.

1 files changed, 3 insertions, 28 deletions

diff --git a/lib/File/stat.t b/lib/File/stat.t
index c3ecc09c62..437078269c 100644
--- a/lib/File/stat.t
+++ b/lib/File/stat.t
@@ -9,37 +9,12 @@ use strict;
 use warnings;
 use Test::More;
 use Config qw( %Config );
-
-my $file;
-
-BEGIN {
-    # Check whether the build is configured with -Dmksymlinks
-    our $Dmksymlinks =
-        grep { /^config_arg\d+$/ && $Config{$_} eq '-Dmksymlinks' }
-        keys %Config;
-
-    # Resolve symlink to ./lib/File/stat.t if this build is configured
-    # with -Dmksymlinks
-    # Originally we worked with ./TEST, but other test scripts read from
-    # that file and modify its access time.
-    $file = '../lib/File/stat.t';
-    if ( $Dmksymlinks ) {
-        $file = readlink $file;
-        die "Can't readlink(../lib/File/stat.t): $!" if ! defined $file;
-    }
-}
-
-# Originally this was done in the BEGIN block, but perl is still
-# compiling (and hence reading) the script at that point, which can
-# change the file's access time, causing a different in the comparison
-# tests if the clock ticked over the second between the stat() and the
-# final read.
-# At this point all of the reading is done.
-our @stat = stat $file; # This is the function stat.
-unless (@stat) { plan skip_all => "1..0 # Skip: no file $file"; exit 0 }
+use File::Temp 'tempfile';
 
 require File::stat;
 
+my (undef, $file) = tempfile();
+my @stat = stat $file; # This is the function stat.
 my $stat = File::stat::stat( $file ); # This is the OO stat.
 isa_ok($stat, 'File::stat', 'should build a stat object' );