fix -Wsign-compare in core

There were a few places that were doing

    unsigned_var = cond ? signed_val : unsigned_val;

or similar. Fixed by suitable casts etc.

The four in utf8.c were fixed by assigning to an intermediate
unsigned var; this has the happy side-effect of collapsing
a large macro expansion, where toUPPER_LC() etc evaluate their arg
multiple times.

1 files changed, 2 insertions, 2 deletions

diff --git a/locale.c b/locale.c
index 7ec3463e84..62841993bc 100644
--- a/locale.c
+++ b/locale.c
@@ -186,11 +186,11 @@ Perl_new_ctype(pTHX_ const char *newctype)
 {
 #ifdef USE_LOCALE_CTYPE
     dVAR;
-    int i;
+    UV i;
 
     PERL_ARGS_ASSERT_NEW_CTYPE;
 
-    for (i = 0; i < 256; i++) {
+    for (i = 0; i ; i++) {
 	if (isUPPER_LC(i))
 	    PL_fold_locale[i] = toLOWER_LC(i);
 	else if (isLOWER_LC(i))