PATCH: [perl #128628] divide by 0 in locale.c

It turned out to be possible to divide by 0 in Win32 when trying to find
the strxfrm() of an empty string.  On other platforms, the result of
this is consistent with other strings, but on Windows, it is longer than
expected, and the code was trying to adapt to this, dividing by the
input length without checking its validity.  This commit just skips the
adapting on a 0-length input.

1 files changed, 6 insertions, 1 deletions

diff --git a/locale.c b/locale.c
index 141def9542..cc3adacccb 100644
--- a/locale.c
+++ b/locale.c
@@ -1779,7 +1779,12 @@ Perl__mem_collxfrm(pTHX_ const char *input_string,
                 STRLEN needed = *xlen + 1;   /* +1 For trailing NUL */
                 STRLEN computed_guess = PL_collxfrm_base
                                       + (PL_collxfrm_mult * length_in_chars);
-                const STRLEN new_m = needed / length_in_chars;
+
+                /* On zero-length input, just keep current slope instead of
+                 * dividing by 0 */
+                const STRLEN new_m = (length_in_chars != 0)
+                                     ? needed / length_in_chars
+                                     : PL_collxfrm_mult;
 
                 DEBUG_Lv(PerlIO_printf(Perl_debug_log,
                     "%s: %d: initial size of %"UVuf" bytes for a length "