[perl #111462] Move strict hints from %^H to $^H

With commit b50b20584, strict.pm starting putting hints in %^H to
indicate that strict mode has been enabled or disabled explicitly, so
version declarations should not change the setting.

This causes ‘Unbalanced string table refcount’ warnings when Safe.pm
encounters prohibited ops.

This happens because ops are leaking when those ops point to HEKs (in
the internal form that %^H takes when attached to ops).

This commit moves those new strict hints into $^H, to avoid those
warnings.  This does simply paper over the real problem (leaked ops),
but at least it gets the warnings back down to the 5.14 amount.

Because of the new hints in $^H, B::Concise has been updated to
account for them, and so have all its tests.  I modified OptreeCheck
to avoid setting the hints with ‘no strict;’, as that resulted in
slightly fewer changes to the tests.  It will also result in fewer
changes to the tests in future.

Two B::Deparse tests started failing due to %^H not being localised.
Apparently there is a bug somewhere (in perl, Deparse.pm or deparse.t)
that got triggered as a result.  In fact, one of the tests exhibited
*two* bugs.  But for now, I’ve simply added a workaround to the two
tests so they don’t trigger those bugs (which bugs will have to wait
till after 5.16).

1 files changed, 6 insertions, 9 deletions

diff --git a/op.c b/op.c
index 1e6addb023..c585b98040 100644
--- a/op.c
+++ b/op.c
@@ -4688,9 +4688,6 @@ Perl_utilize(pTHX_ int aver, I32 floor, OP *version, OP *idop, OP *arg)
 	    newSTATEOP(0, NULL, imop) ));
 
     if (use_version) {
-	HV * const hinthv = GvHV(PL_hintgv);
-	const bool hhoff = !hinthv || !(PL_hints & HINT_LOCALIZE_HH);
-
 	/* Enable the
 	 * feature bundle that corresponds to the required version. */
 	use_version = sv_2mortal(new_version(use_version));
@@ -4699,20 +4696,20 @@ Perl_utilize(pTHX_ int aver, I32 floor, OP *version, OP *idop, OP *arg)
 	/* If a version >= 5.11.0 is requested, strictures are on by default! */
 	if (vcmp(use_version,
 		 sv_2mortal(upg_version(newSVnv(5.011000), FALSE))) >= 0) {
-	    if (hhoff || !hv_exists(hinthv, "strict/refs", 11))
+	    if (!(PL_hints & HINT_EXPLICIT_STRICT_REFS))
 		PL_hints |= HINT_STRICT_REFS;
-	    if (hhoff || !hv_exists(hinthv, "strict/subs", 11))
+	    if (!(PL_hints & HINT_EXPLICIT_STRICT_SUBS))
 		PL_hints |= HINT_STRICT_SUBS;
-	    if (hhoff || !hv_exists(hinthv, "strict/vars", 11))
+	    if (!(PL_hints & HINT_EXPLICIT_STRICT_VARS))
 		PL_hints |= HINT_STRICT_VARS;
 	}
 	/* otherwise they are off */
 	else {
-	    if (hhoff || !hv_exists(hinthv, "strict/refs", 11))
+	    if (!(PL_hints & HINT_EXPLICIT_STRICT_REFS))
 		PL_hints &= ~HINT_STRICT_REFS;
-	    if (hhoff || !hv_exists(hinthv, "strict/subs", 11))
+	    if (!(PL_hints & HINT_EXPLICIT_STRICT_SUBS))
 		PL_hints &= ~HINT_STRICT_SUBS;
-	    if (hhoff || !hv_exists(hinthv, "strict/vars", 11))
+	    if (!(PL_hints & HINT_EXPLICIT_STRICT_VARS))
 		PL_hints &= ~HINT_STRICT_VARS;
 	}
     }