summaryrefslogtreecommitdiff
path: root/op.c
diff options
context:
space:
mode:
authorDavid Mitchell <davem@iabyn.com>2013-11-16 00:01:32 +0000
committerDavid Mitchell <davem@iabyn.com>2013-11-16 00:01:32 +0000
commit659c4b9601a634cd50919970684ee46143183238 (patch)
treeeb876c46404f7b1e190a307d6831e0bc6d651921 /op.c
parent16f3356ebb78fba83c909d19134ee12e98557f24 (diff)
downloadperl-659c4b9601a634cd50919970684ee46143183238.tar.gz
Revert "make perl core quiet under -Wfloat-equal"
A suggested way of avoiding the the warning on nv1 != nv2 by replacing it with (nv1 < nv2 || nv1 > nv2), has too many issues with NaN. [perl #120538]. I haven't found any other way of selectively disabling the warning, so for now I'm just reverting the whole commit. This reverts commit c279c4550ce59702722d0921739b1a1b92701b0d.
Diffstat (limited to 'op.c')
-rw-r--r--op.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/op.c b/op.c
index 412a5ce787..09af08a2f0 100644
--- a/op.c
+++ b/op.c
@@ -1532,8 +1532,7 @@ Perl_scalarvoid(pTHX_ OP *o)
/* the constants 0 and 1 are permitted as they are
conventionally used as dummies in constructs like
1 while some_condition_with_side_effects; */
- else if (SvNIOK(sv) && (NV_eq_nowarn(SvNV(sv), 0.0) ||
- NV_eq_nowarn(SvNV(sv), 1.0)))
+ else if (SvNIOK(sv) && (SvNV(sv) == 0.0 || SvNV(sv) == 1.0))
useless = NULL;
else if (SvPOK(sv)) {
SV * const dsv = newSVpvs("");