diff options
| author | Father Chrysostomos <sprout@cpan.org> | 2012-11-23 20:32:49 -0800 |
|---|---|---|
| committer | Father Chrysostomos <sprout@cpan.org> | 2012-11-24 07:35:50 -0800 |
| commit | 8daf8916b49984fc91791e8265cd7e1ca36b836c (patch) | |
| tree | 286458b2a1b057a66edd69ad1913ed72dabc7fb3 /op.c | |
| parent | 8e3171984bd6a5f4edf04ec5b91032d053bdd8a5 (diff) | |
| download | perl-8daf8916b49984fc91791e8265cd7e1ca36b836c.tar.gz | |
Stop ignored :lvalue warning from leaking CVs
When newMYSUB and newATTRSUB are called, PL_compcv has an unclaimed
reference count, so any code that croaks must decrement the reference
count or make arrangements for such to happen.
Diffstat (limited to 'op.c')
| -rw-r--r-- | op.c | 10 |
1 files changed, 10 insertions, 0 deletions
@@ -7038,7 +7038,12 @@ Perl_newMYSUB(pTHX_ I32 floor, OP *o, OP *proto, OP *attrs, OP *block) const bool pureperl = !CvISXSUB(cv) && CvROOT(cv); if (CvLVALUE(compcv) && ! CvLVALUE(cv) && pureperl && ckWARN(WARN_MISC)) + { + /* protect against fatal warnings leaking compcv */ + SAVEFREESV(PL_compcv); Perl_warner(aTHX_ packWARN(WARN_MISC), "lvalue attribute ignored after the subroutine has been defined"); + SvREFCNT_inc_simple_void_NN(PL_compcv); + } CvFLAGS(cv) |= (CvFLAGS(compcv) & CVf_BUILTIN_ATTRS & ~(CVf_LVALUE * pureperl)); @@ -7444,7 +7449,12 @@ Perl_newATTRSUB_flags(pTHX_ I32 floor, OP *o, OP *proto, OP *attrs, const bool pureperl = !CvISXSUB(cv) && CvROOT(cv); if (CvLVALUE(PL_compcv) && ! CvLVALUE(cv) && pureperl && ckWARN(WARN_MISC)) + { + /* protect against fatal warnings leaking compcv */ + SAVEFREESV(PL_compcv); Perl_warner(aTHX_ packWARN(WARN_MISC), "lvalue attribute ignored after the subroutine has been defined"); + SvREFCNT_inc_simple_void_NN(PL_compcv); + } CvFLAGS(cv) |= (CvFLAGS(PL_compcv) & CVf_BUILTIN_ATTRS & ~(CVf_LVALUE * pureperl)); |