Make constant sub redef warnings obey scope

In perldiag, this is listed as (S), which means that outside of any
use/no warnings scope it always warns, regardless of $^W.

But this warning was ignoring use/no warnings, too.

There were actually tests for this oddity, but I think those were
added by mistake, or this was just not thought through.  I cannot see
how this is not a bug.

1 files changed, 1 insertions, 0 deletions

diff --git a/op.c b/op.c
index 97407ad81a..257e2214d3 100644
--- a/op.c
+++ b/op.c
@@ -6592,6 +6592,7 @@ Perl_newATTRSUB(pTHX_ I32 floor, OP *o, OP *proto, OP *attrs, OP *block)
 				 strEQ(hvname, "autouse"))
 		       ))
 		    || (CvCONST(cv)
+			&& ckWARN_d(WARN_REDEFINE)
 			&& (!const_sv || sv_cmp(cv_const_sv(cv), const_sv))))
 		{
 		    const line_t oldline = CopLINE(PL_curcop);