summaryrefslogtreecommitdiff
path: root/op.h
diff options
context:
space:
mode:
authorFather Chrysostomos <sprout@cpan.org>2011-10-25 17:56:32 -0700
committerFather Chrysostomos <sprout@cpan.org>2011-10-26 18:22:18 -0700
commitd67594ff366291f164fb41e4dcc791494ec4bb0e (patch)
tree3ec3aa27ad2ba46ff773fe14e6a18e31c4882b07 /op.h
parent1bb8785ab1af03172a3a220f8948d33bdc3dd374 (diff)
downloadperl-d67594ff366291f164fb41e4dcc791494ec4bb0e.tar.gz
Fix CORE::glob
This commit makes CORE::glob bypassing glob overrides. A side effect of the fix is that, with the default glob implementa- tion, undefining *CORE::GLOBAL::glob no longer results in an ‘unde- fined subroutine’ error. Another side effect is that compilation of a glob op no longer assumes that the loading of File::Glob will create the *CORE::GLOB::glob type- glob. ‘++$INC{"File/Glob.pm"}; sub File::Glob::csh_glob; eval '<*>';’ used to crash. This is accomplished using a mechanism similar to lock() and threads::shared. There is a new PL_globhook interpreter varia- ble that pp_glob calls when there is no override present. Thus, File::Glob (which is supposed to be transparent, as it *is* the built-in implementation) no longer interferes with the user mechanism for overriding glob. This removes one tier from the five or so hacks that constitute glob’s implementation, and which work together to make it one of the buggiest and most inconsistent areas of Perl.
Diffstat (limited to 'op.h')
-rw-r--r--op.h5
1 files changed, 4 insertions, 1 deletions
diff --git a/op.h b/op.h
index d09ccf1f60..76b17bb721 100644
--- a/op.h
+++ b/op.h
@@ -143,7 +143,10 @@ Deprecated. Use C<GIMME_V> instead.
that was optimised away, so it should
not be bound via =~ */
/* On OP_CONST, from a constant CV */
- /* On OP_GLOB, use Perl glob function */
+ /* On OP_GLOB, two meanings:
+ - Before ck_glob, called as CORE::glob
+ - After ck_glob, use Perl glob function
+ */
/* old names; don't use in new code, but don't break them, either */
#define OPf_LIST OPf_WANT_LIST