diff options
author | Father Chrysostomos <sprout@cpan.org> | 2011-12-17 23:01:07 -0800 |
---|---|---|
committer | Father Chrysostomos <sprout@cpan.org> | 2011-12-17 23:19:04 -0800 |
commit | 8dc99089b7dd2506e907c4344ed28a3206866f37 (patch) | |
tree | 2b28cabfeba32d6a8fc290e622a14e7e0a99cc9b /opcode.h | |
parent | 8cd0c082aacc4c22b60ef4afdb96e244a082d4c1 (diff) | |
download | perl-8dc99089b7dd2506e907c4344ed28a3206866f37.tar.gz |
Stop tell($glob_copy) from clearing PL_last_in_gv
This bug is a side effect of rv2gv’s starting to return an incoercible
mortal copy of a coercible glob in 5.14:
$ perl5.12.4 -le 'open FH, "t/test.pl"; $fh=*FH; tell $fh; print tell'
0
$ perl5.14.0 -le 'open FH, "t/test.pl"; $fh=*FH; tell $fh; print tell'
-1
In the first case, tell without arguments is returning the position of
the filehandle.
In the second case, tell with an explicit argument that happens to
be a coercible glob (tell has an implicit rv2gv, so tell $fh is actu-
ally tell *$fh) sets PL_last_in_gv to a mortal copy thereof, which is
freed at the end of the statement, setting PL_last_in_gv to null. So
there is no ‘last used’ handle by the time we get to the tell without
arguments.
This commit adds a new rv2gv flag that tells it not to copy the glob.
By doing it unconditionally on the kidop, this allows tell(*$fh) to
work the same way.
Let’s hope nobody does tell(*{*$fh}), which will unset PL_last_in_gv
because the inner * returns a mortal copy.
This whole area is really icky. PL_last_in_gv should be refcounted,
but that would cause handles to leak out of scope, breaking programs
that rely on the auto-closing ‘feature’.
Diffstat (limited to 'opcode.h')
-rw-r--r-- | opcode.h | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -1545,7 +1545,7 @@ EXT Perl_check_t PL_check[] /* or perlvars.h */ Perl_ck_fun, /* sysread */ Perl_ck_fun, /* syswrite */ Perl_ck_eof, /* eof */ - Perl_ck_fun, /* tell */ + Perl_ck_tell, /* tell */ Perl_ck_fun, /* seek */ Perl_ck_trunc, /* truncate */ Perl_ck_fun, /* fcntl */ |